Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all sandbox attribute values #1208

Closed
acechorizo opened this issue Feb 27, 2018 · 2 comments · Fixed by #18862
Closed

List all sandbox attribute values #1208

acechorizo opened this issue Feb 27, 2018 · 2 comments · Fixed by #18862
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML idle Issues and pull requests with no recent activity

Comments

@acechorizo
Copy link

This is more of a question than an issue perhaps -

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#Browser_compatibility

In the browser compatibility table, there are some sandbox attributes listed, but there are a whole lot more that are not, such as allow-scripts, allow-same-origin, allow-forms, etc. Am I supposed to read this table as any attribute not specifically called out should be included in the "sandbox" row?

@Elchi3 Elchi3 added data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML question Issues where a question or problem is stated and a discussion is held to gather opinions. labels Mar 5, 2018
@teoli2003
Copy link
Contributor

The answer is "yes". I believe in such cases, we should list all of them individually, though the table would start to be a bit long.

A negative side of implying the values, is that new values, not yet listed, will be implied as supported.

@Elchi3 Elchi3 removed the question Issues where a question or problem is stated and a discussion is held to gather opinions. label Jan 16, 2019
@Elchi3 Elchi3 changed the title sandbox attribute support List all sandbox attribute values Jan 16, 2019
@queengooborg
Copy link
Contributor

queengooborg commented May 3, 2019

I stumbled upon a little something that may help cover this, whether intentionally or not. I noticed a matches.keywords attribute was added to compatibility statements in #3631. Maybe we can use that to our advantage here?

Here's an example in use: https://github.com/mdn/browser-compat-data/blob/master/css/properties/transform.json#L161

The matches object was removed due to lack of use, and adding each individual value is preferred.

@queengooborg queengooborg added schema Isses or pull requests regarding the JSON schema files used in this project. and removed data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Dec 18, 2019
@ddbeck ddbeck added data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML and removed schema Isses or pull requests regarding the JSON schema files used in this project. labels Sep 8, 2020
@github-actions github-actions bot added the idle Issues and pull requests with no recent activity label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML idle Issues and pull requests with no recent activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants