configValidator to check entity class is unique; unit test

Author: mdiyakov

Config/ConfigValidator.php

@@ -4,6 +4,7 @@
 
 use Mdiyakov\DoctrineSolrBundle\Exception\ClientConfigException;
 use Mdiyakov\DoctrineSolrBundle\Exception\ConfigFieldException;
+use Mdiyakov\DoctrineSolrBundle\Exception\EntityClassConfigException;
 use Mdiyakov\DoctrineSolrBundle\Exception\FilterConfigException;
 use Mdiyakov\DoctrineSolrBundle\Exception\RequiredFieldException;
 use Mdiyakov\DoctrineSolrBundle\Exception\SchemaConfigException;
@@ -12,10 +13,15 @@
 class ConfigValidator
 {
     /**
-     * @var array
+     * @var string[]
      */
     private $discriminatorValues = [];
 
+    /**
+     * @var string[]
+     */
+    private $entityClasses = [];
+
     /**
      * @param string[][] $entityConfig
      * @param string[][] $schemes
@@ -33,6 +39,7 @@ public function validate($entityConfig, $schemes, $filters, $clients)
 
         $schemaConfig = $schemes[$entityConfig['schema']];
         $this->checkEntityContainRequiredFields($entityConfig['class'], $schemaConfig);
+        $this->checkClassesForUnique($entityConfig['class']);
         $this->checkConfigFields($entityConfig, $schemaConfig);
         $this->checkFilters($entityConfig, $filters);
         $this->checkClients($schemaConfig, $clients);
@@ -219,4 +226,22 @@ private function checkEntityHasField($entityClass, $entityFieldName)
             );
         }
     }
+
+    /**
+     * @param $entityClass
+     * @throws EntityClassConfigException
+     */
+    private function checkClassesForUnique($entityClass)
+    {
+        if (!in_array($entityClass, $this->entityClasses)) {
+            $this->entityClasses[] = $entityClass;
+        } else {
+            throw new EntityClassConfigException(
+                sprintf(
+                    'It seems entity class "%s" has been configured more than once inside "indexed_entities" section. You can not have different config for the single entity class',
+                    $entityClass
+                )
+            );
+        }
+    }
 }

Tests/Config/ConfigValidatorTest.php

@@ -85,6 +85,16 @@ public function testSchemaNotDefined()
         $this->runConfigTest('schema_not_defined');
     }
 
+    /**
+     * @expectedException \Mdiyakov\DoctrineSolrBundle\Exception\EntityClassConfigException
+     * @expectedExceptionMessage It seems entity class "Mdiyakov\DoctrineSolrBundle\Tests\Config\Entity\MyEntity" has been configured more than once inside "indexed_entities" section. You can not have different config for the single entity class
+     */
+    public function testEntityClassDoubled()
+    {
+        $this->runConfigTest('entity_class_doubled');
+    }
+
+
     /**
      * @expectedException \Mdiyakov\DoctrineSolrBundle\Exception\ConfigFieldException
      * @expectedExceptionMessage "my_enitity_type" discriminator value has already been used.

Tests/Config/config_fixtures.yml

@@ -162,4 +162,26 @@ discriminator_config_not_unique:
             fields:
               - {  entity_field_name: 'id', document_field_name: 'd_id', field_type: int, entity_primary_key: true }
     filters: []
+    solarium_clients: []
+
+entity_class_doubled:
+    indexed_entities:
+        my_entity:
+            class:  Mdiyakov\DoctrineSolrBundle\Tests\Config\Entity\MyEntity
+            schema: my_schema
+            config:
+              - { name: type, value: page }
+        my_entity_2:
+            class:  Mdiyakov\DoctrineSolrBundle\Tests\Config\Entity\MyEntity
+            schema: my_schema
+            config:
+              - { name: type, value: page }
+    schemes:
+        my_schema:
+            document_unique_field: { name: 'uid' }
+            config_entity_fields:
+              - {  config_field_name: 'type', document_field_name: 'type', discriminator: true, priority: 50 }
+            fields:
+              - {  entity_field_name: 'id', document_field_name: 'd_id', field_type: int, entity_primary_key: true }
+    filters: []
     solarium_clients: []