Skip to content

Commit 9856751

Browse files
computersforpeacemcgrof
authored andcommitted
crda: Makefile: fix .so compilation line with some compilers
Write the CC rule such that it only tries to produce a single output file (the .so). When including the .h files in the compiler invocation, this suggests we should be producing pre-compiled headers too, which doesn't make sense in this context, and Clang happens not to like. Signed-off-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
1 parent f4ef253 commit 9856751

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
114114
$(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
115115
$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
116116

117-
$(LIBREG): regdb.h reglib.h reglib.c
117+
$(LIBREG): reglib.c regdb.h reglib.h
118118
$(NQ) ' CC ' $@
119-
$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
119+
$(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
120120

121121
install-libreg-headers:
122122
$(NQ) ' INSTALL libreg-headers'

0 commit comments

Comments
 (0)