Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't issue raw rollback #948

Open
0x0badc0de opened this issue Mar 11, 2019 · 0 comments
Open

Don't issue raw rollback #948

0x0badc0de opened this issue Mar 11, 2019 · 0 comments

Comments

@0x0badc0de
Copy link

0x0badc0de commented Mar 11, 2019

PR #809 includes a code which issues raw rollback into a database rolling back all the changes made before calling this code. There was very valid comment regarding this #809 (comment)
Can this code be refactored at least to use nested transaction, raise ActiveRecord::Rollback (or another one) or even rethrow original exception probably configured w/ some option. It would be much better to have an exception in caller code rather than all the changes silently discarded by raw rollback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant