You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #809 includes a code which issues raw rollback into a database rolling back all the changes made before calling this code. There was very valid comment regarding this #809 (comment)
Can this code be refactored at least to use nested transaction, raise ActiveRecord::Rollback (or another one) or even rethrow original exception probably configured w/ some option. It would be much better to have an exception in caller code rather than all the changes silently discarded by raw rollback.
The text was updated successfully, but these errors were encountered:
PR #809 includes a code which issues raw rollback into a database rolling back all the changes made before calling this code. There was very valid comment regarding this #809 (comment)
Can this code be refactored at least to use nested transaction, raise ActiveRecord::Rollback (or another one) or even rethrow original exception probably configured w/ some option. It would be much better to have an exception in caller code rather than all the changes silently discarded by raw rollback.
The text was updated successfully, but these errors were encountered: