Spotted two bugs in acts_as_taggable_on.rb

[lemig]

Hi,

This a great plugin. Here two small bugs.

in : find_options_for_find_tagged_with()
change : conditions << sanitize_sql(["context = ?",on.to_s])
to : conditions << sanitize_sql(["#{Tagging.table_name}.context = ?",on.to_s])

in : find_options_for_tag_counts()
change:
{ :select => "#{Tag.table_name}.id, #{Tag.table_name}.name, COUNT() AS count",
:joins => joins.join(" "),
:conditions => conditions,
:group => group_by
}
to :
{ :select => "#{Tag.table_name}.id, #{Tag.table_name}.name, COUNT() AS count",
:joins => joins.join(" "),
:conditions => conditions,
:group => group_by,
:order => options[:order]
}

Best regards,

miguel cabero

[lemig]

forget the first bug correction, here is the right change :
in : find_options_for_find_tagged_with()
change :

unless (on = options.delete(:on)).nil?
conditions << sanitize_sql(["#{context = ?",on.to_s])
end
taggings_alias, tags_alias = "#{table_name}_taggings", "#{table_name}_tags"

to :
taggings_alias, tags_alias = "#{table_name}_taggings", "#{table_name}_tags"
unless (on = options.delete(:on)).nil?
conditions << sanitize_sql(["#{taggings_alias}.context = ?",on.to_s])
end

[eet-nu]

Pretty sure this is fixed now, as I rewrote find_options_for_find_tagged_with.