Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on Rails 7.1 upgrade #1112

Closed
ajdubovoy opened this issue Oct 12, 2023 · 9 comments
Closed

Issue on Rails 7.1 upgrade #1112

ajdubovoy opened this issue Oct 12, 2023 · 9 comments

Comments

@ajdubovoy
Copy link

I just upgraded a project to Rails 7.1. It seems to actually run fine in the server, but I've started getting some red Rspec tests that seem to be related to this gem:

warning: already initialized constant ActsAsTaggableOn::Tagging::DEFAULT_CONTEXT
Failure/Error: let(:invitation) { create(:invitation, user:) }
     
     NoMethodError:
       undefined method `arity' for {:polymorphic=>true}:Hash
     
             if scope && scope.arity == 0

I get this same error on each test.

Thanks for your help!

@jon-sully
Copy link

I just ran into this as well. Everything actually works fine when running directly on master, and I think prior to, some dependency issues forced us to be running on a fairly old version (5.x.x?) to begin with. I think master is good for Rails 7.1.

@seuros
Copy link
Collaborator

seuros commented Oct 14, 2023

Can you try #1114 please.

@jon-sully
Copy link

Sure! Let me run it against our suite.

@jon-sully
Copy link

Yep, both master and v10 pre-release worked fine for me 👍

@seuros
Copy link
Collaborator

seuros commented Oct 14, 2023

I will merge it and release it tomorrow then.

@jon-sully
Copy link

Sweet! 😎

@h0jeZvgoxFepBQ2C
Copy link
Contributor

Great, waiting for the release.. Thank you so much!

@ajdubovoy
Copy link
Author

Thank you so much for your help!!

@seuros
Copy link
Collaborator

seuros commented Oct 15, 2023

Released

@seuros seuros closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants