Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update grafana dashboard for metrics deprecated by 1.2.0 #6035

Open
ptman opened this issue Sep 13, 2019 · 10 comments
Open

Update grafana dashboard for metrics deprecated by 1.2.0 #6035

ptman opened this issue Sep 13, 2019 · 10 comments
Labels
A-Metrics metrics, measures, stuff we put in Prometheus O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@ptman
Copy link
Contributor

ptman commented Sep 13, 2019

Description:

contrib/grafana/synapse.json seems to be older than synapse 1.2.0 that changed prometheus metrics names.

Can you please update the grafana dashboard? Just a quick dump of your current one if it isn't too specialized?

@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p2 (Deprecated Label) maintenance and removed z-bug (Deprecated Label) labels Sep 13, 2019
@richvdh richvdh changed the title Update grafana dashboard Update grafana dashboard for metrics deprecated by 1.2.0 Sep 17, 2019
@richvdh
Copy link
Member

richvdh commented Sep 17, 2019

worth noting that the old names are still available, just deprecated. We haven't yet updated the dashboard.

@ptman
Copy link
Contributor Author

ptman commented Sep 17, 2019

Oh, great! Wonder why it looks so empty then

@richvdh
Copy link
Member

richvdh commented Sep 17, 2019

try increasing the bucket size a bit

@richvdh
Copy link
Member

richvdh commented Sep 18, 2019

@neilisfragile why is this todo rather than holding pen?

@richvdh
Copy link
Member

richvdh commented Mar 19, 2020

this is still a thing that we ought to do, incidentally.

@abeluck
Copy link

abeluck commented Sep 18, 2020

Looks like the dashboard was updated in July: https://github.com/matrix-org/synapse/commits/develop/contrib/grafana/synapse.json

@richvdh
Copy link
Member

richvdh commented Sep 21, 2020

it was, but it still uses the deprecated metrics afaik

@immanuelfodor
Copy link

What is the current state of the JSON file? It was last updated 5 months ago, and there have been many releases since then. Is it up-to-date?

@richvdh
Copy link
Member

richvdh commented Dec 14, 2020

yes, a release does not invalidate the dashboard definition.

@MadLittleMods MadLittleMods added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. A-Metrics metrics, measures, stuff we put in Prometheus labels Nov 10, 2021
@DMRobertson DMRobertson added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-p2 (Deprecated Label) z-maintenance labels Aug 25, 2022
@DMRobertson
Copy link
Contributor

Possibly of interest in the light of #13540?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Metrics metrics, measures, stuff we put in Prometheus O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

7 participants