This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update grafana dashboard for metrics deprecated by 1.2.0 #6035
Labels
A-Metrics
metrics, measures, stuff we put in Prometheus
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Comments
worth noting that the old names are still available, just deprecated. We haven't yet updated the dashboard. |
Oh, great! Wonder why it looks so empty then |
try increasing the bucket size a bit |
@neilisfragile why is this todo rather than holding pen? |
this is still a thing that we ought to do, incidentally. |
Looks like the dashboard was updated in July: https://github.com/matrix-org/synapse/commits/develop/contrib/grafana/synapse.json |
it was, but it still uses the deprecated metrics afaik |
What is the current state of the JSON file? It was last updated 5 months ago, and there have been many releases since then. Is it up-to-date? |
yes, a release does not invalidate the dashboard definition. |
Possibly of interest in the light of #13540? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Metrics
metrics, measures, stuff we put in Prometheus
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Description:
contrib/grafana/synapse.json
seems to be older than synapse 1.2.0 that changed prometheus metrics names.Can you please update the grafana dashboard? Just a quick dump of your current one if it isn't too specialized?
The text was updated successfully, but these errors were encountered: