Synapse reads timeout on /keys/query CS endpoint as a query parameter, not from the JSON body

[DMRobertson]

synapse/synapse/rest/client/keys.py

Lines 160 to 182 in d3d9ca1

	async def on_POST(self, request: SynapseRequest) -> Tuple[int, JsonDict]:
	requester = await self.auth.get_user_by_req(request, allow_guest=True)
	user_id = requester.user.to_string()
	device_id = requester.device_id
	timeout = parse_integer(request, "timeout", 10 * 1000)
	body = parse_json_object_from_request(request)
	device_keys = body.get("device_keys")
	if not isinstance(device_keys, dict):
	raise InvalidAPICallError("'device_keys' must be a JSON object")
	def is_list_of_strings(values: Any) -> bool:
	return isinstance(values, list) and all(isinstance(v, str) for v in values)
	if any(not is_list_of_strings(keys) for keys in device_keys.values()):
	raise InvalidAPICallError(
	"'device_keys' values must be a list of strings",
	)
	result = await self.e2e_keys_handler.query_devices(
	body, timeout, user_id, device_id
	)
	return 200, result

Spec: https://spec.matrix.org/v1.4/client-server-api/#post_matrixclientv3keysquery

Would be ideally fixed by #14266.

[DMRobertson]

AFAICS dendrite follows the spec.