Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

The synapse_review_recent_signups script should have a flag to ignore and filter appservice users #10699

Closed
maranda opened this issue Aug 25, 2021 · 3 comments
Closed

The synapse_review_recent_signups script should have a flag to ignore and filter appservice users #10699

maranda opened this issue Aug 25, 2021 · 3 comments
Labels
good first issue Good for newcomers S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@maranda
Copy link

maranda commented Aug 25, 2021

As the topic says, a server whit bridges would otherwise have a pretty polluted output.
@reivilibre reivilibre added good first issue Good for newcomers S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Aug 26, 2021
@reivilibre
Copy link
Contributor

This seems like a reasonable improvement.

It could be done by altering the query on the users table to say AND appservice_id IS NOT NULL.

@reivilibre reivilibre changed the title synapse_review_recent_signups should have a flag to ignore and filter appservice users The synapse_review_recent_signups script should have a flag to ignore and filter appservice users Aug 26, 2021
@lukasdenk
Copy link
Contributor

I'll work on it :)

@lukasdenk lukasdenk mentioned this issue Jan 3, 2022
Merged
4 tasks
@lukasdenk
Copy link
Contributor

@maranda: I solved the issue in the above PR. Could you please close the issue? Thanks :)

@maranda maranda closed this as completed Jan 19, 2022
@richvdh richvdh mentioned this issue Jan 19, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maranda @reivilibre @lukasdenk