This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Report verification and recovery state to posthog #12516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
added
the
T-Task
BillCarsonFr
force-pushed
the
valere/posthog_report_verification_recovery_state
branch
from
de4adf7 to
4a55f48
Compare
BillCarsonFr
force-pushed
the
valere/posthog_report_verification_recovery_state
branch
from
5cbc0b6 to
c3eb8c7
Compare
|
This says:
... so I don't think this change is necessary? |
The issue specifically says I'd like to know the numbers for EX and EW. |
The issue seems contradictory, but ok. |
richvdh
suggested changes
May 14, 2024
MidhunSureshR
approved these changes
May 21, 2024
BillCarsonFr
deleted the
valere/posthog_report_verification_recovery_state
branch
thoraj
added a commit
to verji/matrix-react-sdk
that referenced
this pull request
Aug 15, 2024
* Upgrade dependency to matrix-js-sdk@32.3.0-rc.0 * v3.100.0-rc.0 * Upgrade dependency to matrix-js-sdk@32.3.0 * Remove code smell assertion identified by Sonar (matrix-org#12547) * This assertion is unnecessary since the receiver accepts the original type of the expression * Implement `client.getDomain()` null check * Update comment since `AutoDiscovery.findClientConfig` may still throw * Report verification and recovery state to posthog (matrix-org#12516) * Report verification and recovery state to posthog * Fix CryptoApi import * Fix js-sdk import * Review: Use DeviceVerificationStatus instead of CrossSigningStatus * Review: Clean condition to check secrets in 4S * review: Fix redundent !! * Deprecate `Tooltip.tsx` * Use tooltip compound in `MessageComposer.tsx` * Use tooltip compound in `ReadReceiptGroup` component * Use tooltip compound in `ReadReceiptPerson` component * Delete `useTooltip.tsx` * Use compound tooltip in `ReactionRowButton` * Upgrade dependency to matrix-js-sdk@32.4.0 * Migrate `TooltipTarget` usage to compound `Tooltip` (matrix-org#12542) * Use new tooltip in `RoomTopic.tsx` * Use new tooltip in `MLocationBody.tsx` * Fix room topic * Update location snapshot * Use new tooltip in `AppPermission.tsx` * Remove `TooltipTarget` * Add tests for `RoomTopic` * Add tests for `ReadReceiptGroup.tsx` * Add more tests for `ReadReceiptGroup.tsx` * Add more test for `ReactionsRowButton.tsx` * Add seedrandom dep to `resolutions` (matrix-org#12552) * Move seedrandom dep to `resolutions` ... to shut renovate up * Reinstate `seedrandom` as dev dependency If we just declare it in `resolutions`, it doesn't get installed at all, because it is only a devDependency of `bloom-filters`. * [create-pull-request] automated change (matrix-org#12554) Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com> * Avoid using deprecated exports, fields, and duplicate code (matrix-org#12555) * Fix tabbedview breakpoint width (matrix-org#12556) Which should be 1024 according to the designs, not 768 * Tooltip: close field tooltip when ESC is pressed (matrix-org#12553) * Close field tooltip when ESC is pressed * Use `Key.ESCAPE` * Close the release announcement when a dialog is opened (matrix-org#12559) * Fire `ModalManagerEvent.Closed` when a dialog is closed * Listen to modal events in the RA * Fix first RA test * Upgrade dependency to matrix-js-sdk@33.0.0-rc.0 * v3.100.0-rc.1 * Upgrade dependency to matrix-js-sdk@33.0.0 * v3.100.0 --------- Co-authored-by: RiotRobot <releases@riot.im> Co-authored-by: Ed Geraghty <edg@privacyinternational.org> Co-authored-by: Valere <valeref@matrix.org> Co-authored-by: Florian Duros <florian.duros@ormaz.fr> Co-authored-by: Florian Duros <florianduros@element.io> Co-authored-by: David Baker <dbkr@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/element-hq/crypto-internal/issues/226
Updating analytics-event to 0.21.0
The reporting to posthog is added in the
DeviceListenerwhere there is already logic to check state to prompt to verify or setup 4S.This reports a user property as well as status change event when the verification state or the recovery state changes:
https://github.com/matrix-org/matrix-analytics-events/blob/fd0fe7894a8d47497d87bb90b985f6094447ef77/schemas/CryptoSessionStateChange.json#L3
Checklist
public/exportedsymbols have accurate TSDoc documentation.