Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove review popup #18250

Closed
Tracked by #18186
tsteur opened this issue Oct 31, 2021 · 0 comments · Fixed by #18262
Closed
Tracked by #18186

Remove review popup #18250

tsteur opened this issue Oct 31, 2021 · 0 comments · Fixed by #18262
Assignees
@peterhashair
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.6.0

Comments

@tsteur
Copy link
Member

tsteur commented Oct 31, 2021

We have a logic to show a popup like below to ask for a review on few review sites. The feature was added in #14432

image

We'd like to remove this feature as it's not much used.

We're also removing the "refer us" feature in #18232

We're still asking for a review after a user rated a feature positive. We would keep this feature.
@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Oct 31, 2021
@tsteur tsteur added this to the 4.6.0 milestone Oct 31, 2021
@tsteur tsteur mentioned this issue Oct 31, 2021
Closed
2 tasks
@tsteur tsteur added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Nov 1, 2021
@peterhashair peterhashair self-assigned this Nov 1, 2021
@peterhashair peterhashair mentioned this issue Nov 1, 2021
Closed
11 tasks
@peterhashair peterhashair linked a pull request Nov 4, 2021 that will close this issue
add feedback question, remove other related. #18262
Merged
11 tasks
@peterhashair peterhashair mentioned this issue Nov 4, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.6.0
2 participants
@tsteur @peterhashair