Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a logic to self-heal StateSynced and StakeUpdate events #837

Merged
merged 14 commits into from
Jun 20, 2022
Merged

Added a logic to self-heal StateSynced and StakeUpdate events #837

merged 14 commits into from
Jun 20, 2022
+816 −535

Conversation

begmaroman
Copy link
Contributor

No description provided.

@begmaroman begmaroman self-assigned this Jun 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022 •
edited
Loading

Codecov Report

Merging #837 (c94a630) into develop (81722d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #837   +/-   ##
========================================
  Coverage    72.69%   72.69%           
========================================
  Files           49       49           
  Lines         3549     3549           
========================================
  Hits          2580     2580           
  Misses         740      740           
  Partials       229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81722d2...c94a630. Read the comment docs.

JekaMas
JekaMas reviewed Jun 15, 2022
View reviewed changes
JekaMas
JekaMas reviewed Jun 15, 2022
View reviewed changes
JekaMas
JekaMas previously approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@JekaMas JekaMas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just few minor comments

@begmaroman begmaroman requested review from JekaMas and 0xKrishna June 15, 2022 14:50
@begmaroman begmaroman marked this pull request as ready for review June 15, 2022 14:50
0xKrishna
0xKrishna previously approved these changes Jun 17, 2022
View reviewed changes
temaniarpit27
temaniarpit27 requested changes Jun 20, 2022
View reviewed changes
@temaniarpit27
Copy link
Contributor

Also, please look into the active notifications tool as well

@begmaroman
Copy link
Contributor Author

@temaniarpit27 I was planning to add an alerting logic within the next separate PR. It would be easier to track changes.

JekaMas
JekaMas reviewed Jun 20, 2022
View reviewed changes
JekaMas
JekaMas reviewed Jun 20, 2022
View reviewed changes
@begmaroman begmaroman requested a review from JekaMas June 20, 2022 12:56
@begmaroman begmaroman merged commit 2324802 into develop Jun 20, 2022
@begmaroman begmaroman deleted the feature/adding-stake-update-self-heal-logic branch June 20, 2022 14:44
@begmaroman begmaroman changed the title Added a logic to self-heal StateSynced events Added a logic to self-heal StateSynced and StakeUpdate events Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

@JekaMas JekaMas JekaMas approved these changes

@0xsharma 0xsharma 0xsharma approved these changes

@0xKrishna 0xKrishna 0xKrishna approved these changes

Assignees

@begmaroman begmaroman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@begmaroman @codecov-commenter @temaniarpit27 @JekaMas @0xsharma @0xKrishna