Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .heic images #348

Open
ntimo opened this issue Oct 19, 2020 · 5 comments
Open

Add support for .heic images #348

ntimo opened this issue Oct 19, 2020 · 5 comments

Comments

@ntimo
Copy link

ntimo commented Oct 19, 2020

Expected behaviour

.heic images should be scanned and analysed for faces.

Actual behaviour

.heic images are not analysed

Steps to reproduce

  1. Use any apple device to take pictures in .heic format
  2. Wait for them to be analysed
  3. See they are not analysed

Additional Info

It seems to be related to this line there

private $allowedMimetypes = ['image/jpeg', 'image/png'];
that sets the allowed image formats for the analysis.

Heic mime type image/heic

iOS devices capture photos in the heic format, so having support for it would be huge. (https://support.apple.com/en-us/HT207022)

By the way, the app is amazing thanks for creating it.

@ntimo
Copy link
Author

ntimo commented Oct 19, 2020

I also tried settings this in my nextcloud config but when I then run the background job the heic images are not processed.

  'enabledFaceRecognitionMimetype' =>
  array (
    0 => 'image/png',
    1 => 'image/jpeg',
    2 => 'image/heic'
  ),

@matiasdelellis
Copy link
Owner

Hi @ntimo
You're right. We have not yet implemented HEIC support. It's on the roadmap, but we still have to wait a bit.. Sorry..

@StarSmasher44
Copy link

Hey there, is this still something that could be added? Most recent phones nowadays have HEIC supported and like mine have it on by default, I actually spent some time trying to debug this 'issue' but I believe it is simply because it is still not supported

@matiasdelellis
Copy link
Owner

matiasdelellis commented Dec 15, 2022

Wow, it took me two years, but I finally got it done. With this, soon a version 1.0. 😬

#616

@nssatlantis
Copy link

Wow, it took me two years, but I finally got it done. With this, soon a version 1.0. 😬

#616

I wouls like to personally say THANK YOU!
One of the first to actually support .heic within NextCloud I reckon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants