Fix RuntimeError triggered in CI of downstream packages #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if running in pymatgen's own CI
…mpy.float64` instead
…precate with monty decorator
janosh
added
fix
4 tasks
|
Has this issue been fixed? It looks like I am still seeing this error in my CI test. https://github.com/qzhu2017/PyXtal/actions/runs/8304091691/job/22729255439 |
|
this was released 2 weeks ago in v2024.3.1. your errors should disappear once you update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a major problem with how deprecation removal reminders are currently setup for CI causing other package CI runs to fail. in this case with
this will affect any package using
pymatgenin CI.this PR solves the issue in two places
CifParser.parse_structures()andBaderAnalysis._parse_atomic_densities().i'll make a hot-fix release right after this is merged. thanks @BowenD-UCB for reporting!
this poorly written code was added by me in 9e27ca8 and released in v2023.11.10. given this affects all intermediate releases, it's probably too much to yank them all from PyPI:
luckily, the error will only show up in CI runs, not in user-facing code.