Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label propagation in Symmetry.from_spacegroup #3527

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

stefsmeets
Copy link
Contributor

Hi all, another small PR that makes sure labels are passed when a Symmetry.from_spacegroup is used. This follows-up on an earlier PR: #3183

Summary

Major changes:

  • fix 1: Fix label propagation in Symmetry.from_spacegroup

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@janosh janosh added fix Bug fix PRs symmetry Space groups and the like core Pymatgen core labels Dec 19, 2023
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefsmeets!

@janosh janosh merged commit 1dd74a8 into materialsproject:master Dec 19, 2023
@stefsmeets stefsmeets deleted the fix-label-propagation branch December 19, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pymatgen core fix Bug fix PRs symmetry Space groups and the like
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants