-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradient, Hessian, and orbital coeffs scratch file parsers to pymatgen.io.qchem.outputs
#3483
Conversation
Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
pymatgen.io.qchem.outputs
pymatgen.io.qchem.outputs
pymatgen.io.qchem.outputs
pymatgen.io.qchem.outputs
pymatgen.io.qchem.outputs
pymatgen.io.qchem.outputs
@janosh: This should be ready for review. As I mentioned above, this code was largely written by @samblau --- I added some simple tests and cleaned up the linting errors. Longer term, it would probably make sense to create a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Andrew-S-Rosen, looks great! Just a minor suggestion re test file compression.
it would probably make sense to create a new QCScratch(MSONable) class that parses scratch files in a directory. However, I have not implemented that here (unless you feel it necessary).
Tbh I don't feel qualified to make that call
@janosh: Thanks! I gzip'd the files. Should be good to go from my end at least :) |
@janosh: All good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Andrew-S-Rosen! 👍
Enabled by materialsproject/pymatgen#3483. Waiting on the next release of pymatgen. --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Summary
This PR adds function to
pymatgen.io.qchem.outputs
to parse (scratch) gradient, Hessian, and previous orbital coefficient files made by Q-Chem.Note: 99% of the credit for this goes to @samblau. I am simply moving it into pymatgen where it belongs.
Todos
I need to add tests. There are also some things that are definitely better done with numpy vectorization, but it's not a huge issue.
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: