-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting of Multicenter COBIs #2926
Conversation
… multi_center_COBICAR
Just as a warning that this might sit here for a longer time. I discovered an issue for the multi-center COBI computations in Lobster for the spin-polarized case during the plotting implementation. I will wait until there is a new Lobster version that can generate useful test data. |
Will try to finalize a first implementation soon. I have not forgotten about this pull request. |
3c23114
to
36e289c
Compare
d725325
to
dca98be
Compare
… multi_center_COBICAR
… multi_center_COBICAR
@janosh if you have some time to review this, this would be awesome. If we don't merge it soon, this will never get merged as tons of merge conflicts show up very fast here in pymatgen and it would be sad as it was a lot of work ... |
… multi_center_COBICAR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i renamed multicenter_cobis
to multi_center_cobis
since it was flagged by cSpell
. let me know if this negatively affects downstream code
@janosh , The renaming is fine as it is not used yet anywhere. |
Summary
Lobster now also has options to compute multi-center interactions. This leads to a different format of the COBICAR.lobster (e.g., no average COBI is included) and the labels of the bonds are different. At this stage, I can already plot this different format but no tests are included so far. Bond lengths are missing in this output. I might add a computation of those based on the site index and cell number of the interacting atoms.
TODO: