This repository was archived by the owner on Jan 13, 2025. It is now read-only.
feat(menu): Added new API to manually set focus when menu is opened #4468
+296
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the Don't forget to update the commit message before you hit "Squash and merge" 😀 |
acdvorak
previously requested changes
Mar 1, 2019
abhiomkar
commented
Mar 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
=========================================
Coverage ? 99.02%
=========================================
Files ? 130
Lines ? 6277
Branches ? 820
=========================================
Hits ? 6216
Misses ? 60
Partials ? 1
Continue to review full report at Codecov.
|
|
Ping. |
kfranqueiro
suggested changes
Mar 15, 2019
kfranqueiro
reviewed
Mar 15, 2019
abhiomkar
commented
Mar 15, 2019
kfranqueiro
approved these changes
Mar 18, 2019
abhiomkar
dismissed
acdvorak’s stale review
Andy's review comments are resolved
|
🤖 Beep boop! Screenshot test report 🚦9 screenshots changed from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3922
Superseded by changes in PR #4587
BREAKING CHANGE: Focus is no more set to first menu item when menu is opened. Introduced new API (
setDefaultFocusItemIndex()) to set focus on specific menu item every time the menu is opened. Also introduced new foundation & adapter methods to incorporate this change. Please usesetDefaultFocusItemIndex(0)method before menu open to retain previous behaviour.