Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox ffmpeg by default #8648

Closed
1 task done
ghost opened this issue Sep 8, 2018 · 1 comment · Fixed by #8855
Closed
1 task done

sandbox ffmpeg by default #8648

ghost opened this issue Sep 8, 2018 · 1 comment · Fixed by #8855

Comments

@ghost
Copy link

ghost commented Sep 8, 2018

ffmpeg is project with a lot of security fixes shipped every version. Adding firejail, other than adding SELinux or AppArmor support, is fast and portable across all Linux 3.x+ targets and provides some protection from malicious user input.

A profile for ffmpeg that works with Mastodon out of the box ships with firejail, but could probably be refined (e.g. Mastodon doesn't need ffmpeg to have write access to the FS).

I've written a guide on how to set this up manually.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@abochmann
Copy link

abochmann commented Sep 8, 2018

@sascha-sl Tried that configuration, but I see no signs of the ffmpeg wrapper actually being used by Mastodon, specifically by paperclip (is ffmpeg being called from anywhere else?).
Paperclip also doesn't seem to have any configuration options to provide paths for individual binaries. From quickly browsing docs, the only way I see is to provide a directory with wrappers for all the programs that paperclip expects to find, and then point to that using the command_path configuration option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant