Skip to content
This repository has been archived by the owner on Feb 13, 2025. It is now read-only.

Consider moving this to the objc2 project? #2

Closed
madsmtm opened this issue Dec 17, 2024 · 9 comments
Closed

Consider moving this to the objc2 project? #2

madsmtm opened this issue Dec 17, 2024 · 9 comments

Comments

@madsmtm
Copy link

madsmtm commented Dec 17, 2024

Hey @marysaka, nice work you've been doing here!

I've been considering integrating libdispatch into objc2 for a while myself, but haven't really built up enough inertia to seriously consider doing so - that is, before today!

Specifically, I need this to enable objc2 encoding and block2 support (so I cannot yet use the crate as-is).

The big reason I'm asking is because the crate name would fit the (admittedly somewhat haphazard) naming-scheme in the objc2 project: That libraries get distinct crate names with a "2", while frameworks are prefixed with objc2. I.e.:

  • libblocks -> block2
  • libobjc -> objc2
  • libdispatch -> dispatch2
  • Framework -> objc2-*

If you say no, which is perfectly acceptable, I'll just fork and use the name objc2-dispatch, it's not a big deal for me, it'd just be nice ;)

(I recognize that it is a bit rude for me to effectively ask you to give up ownership of your project, I'm sorry, I didn't know of a better way to write it, I apologize in advance if I've offended you by that, please feel free to ignore if that is the case, I sincerely mean no harm by this proposal!)

@marysaka
Copy link
Owner

Hey!

The big reason I'm asking is because the crate name would fit the (admittedly somewhat haphazard) naming-scheme in the objc2 project: That libraries get distinct crate names with a "2", while frameworks are prefixed with objc2. I.e.:

* `libblocks` -> `block2`

* `libobjc` -> `objc2`

* `libdispatch` -> `dispatch2`

* Framework -> `objc2-*`

If you say no, which is perfectly acceptable, I'll just fork and use the name objc2-dispatch, it's not a big deal for me, it'd just be nice ;)

Sure I don't mind, I suppose your username is the same on crates.io? 😄

(I recognize that it is a bit rude for me to effectively ask you to give up ownership of your project, I'm sorry, I didn't know of a better way to write it, I apologize in advance if I've offended you by that, please feel free to ignore if that is the case, I sincerely mean no harm by this proposal!)

Don't worry it is completely fine!

The only reason for that project existence was to replace the existing dispatch crate with something at least a bit safer that I could use with objc2 on my iOS projects.

I haven't touch *OS dev for quite a while and never had time to finish integrating things properly so I'm quite happy if you want to take it over 👍

@madsmtm
Copy link
Author

madsmtm commented Dec 17, 2024

Sure I don't mind

Awesome!

I suppose your username is the same on crates.io? 😄

Yup: https://crates.io/users/madsmtm

The only reason for that project existence was to replace the existing dispatch crate with something at least a bit safer that I could use with objc2 on my iOS projects.

I haven't touch *OS dev for quite a while and never had time to finish integrating things properly so I'm quite happy if you want to take it over 👍

I'll try my best to steward the project well, and make it even safer ;)

@marysaka
Copy link
Owner

Should have invited you on crates.io, I will update this repo readme and archive it when you will have published the first version on crates.io

@madsmtm
Copy link
Author

madsmtm commented Dec 17, 2024

Cool! That might take a few weeks, but I'll shoot you a message here once it does happen.

@pronebird
Copy link

This is awesome! Thanks both of you!

@madsmtm
Copy link
Author

madsmtm commented Jan 22, 2025

Hey, do you mind if I relicense your work under the trio license Zlib OR Apache-2.0 OR MIT as well? My motivation is mostly that it'll make it easier for me to write down what the license of the code actually is (fewer exceptions).

See also madsmtm/objc2#23.

@marysaka
Copy link
Owner

@madsmtm Sure go ahead 👍

madsmtm added a commit to madsmtm/objc2 that referenced this issue Jan 22, 2025
@madsmtm
Copy link
Author

madsmtm commented Jan 23, 2025

I've released a new version of dispatch2 now! I didn't yet get around to doing a bunch of the refactoring I have planned (though the ffi module has been expanded by quite a lot), but there's work in progress on that here.

@marysaka
Copy link
Owner

Hi, just pushed an update of the readme here, I will archive the repo now!

Thank you for your work 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants