Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default App loading view does not center vertically on screen. #4302

Closed
WiXSL opened this issue Jan 16, 2020 · 4 comments · Fixed by #4686
Closed

Default App loading view does not center vertically on screen. #4302

WiXSL opened this issue Jan 16, 2020 · 4 comments · Fixed by #4686
Labels
enhancement good first issue

Comments

@WiXSL
Copy link
Contributor

WiXSL commented Jan 16, 2020

To solve it I use the loader-container css class from the demo.

<Admin
     loading={() => <Loading className="loader-container"/>}
     ...
>

Sandbox: https://codesandbox.io/s/mystifying-dirac-lo5m1
Note: You have to enlarge the sandbox frame in order to see it.

Screenshot of mystifying-dirac-lo5m1 - CodeSandbox

Using version 3.1.2.
@djhi
Copy link
Collaborator

djhi commented Jan 17, 2020

Confirmed. Thanks

@manishsundriyal
Copy link
Contributor

@fzaninotto @djhi Can I work on this?

@djhi
Copy link
Collaborator

djhi commented Apr 14, 2020

@manishsundriyal Please do ! :)

@manishsundriyal manishsundriyal mentioned this issue Apr 14, 2020
Merged
@manishsundriyal
Copy link
Contributor

@djhi Please review and merge #4686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default app loading is not not center vertically - 4302 manishsundriyal/react-admin
4 participants
@fzaninotto @djhi @WiXSL @manishsundriyal