Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade 3.0.0-beta.2 to 3.0.0-beta.3 some file failed #3924

Closed
anewcoder1992 opened this issue Nov 4, 2019 · 9 comments
Closed

upgrade 3.0.0-beta.2 to 3.0.0-beta.3 some file failed #3924

anewcoder1992 opened this issue Nov 4, 2019 · 9 comments
Assignees
Labels

Comments

@anewcoder1992
Copy link

anewcoder1992 commented Nov 4, 2019

What you were expecting:
upgrade react-admin to 3.0.0-beta.3 from beta.2.

What happened instead:
some file have problem :convertLegacyDataProvider.ts

image
Steps to reproduce:
yarn upgrade react-admin@3.0.0-beta.3
Related code:

import {
    CREATE,
    DELETE,
    DELETE_MANY,
    GET_LIST,
    GET_MANY,
    GET_MANY_REFERENCE,
    GET_ONE,
    UPDATE,
    UPDATE_MANY,
} from '../core';

../core did not export right path.

Environment

  • React-admin version:3.0.0-beta.2
@Kmaschta
Copy link
Contributor

Kmaschta commented Nov 4, 2019

Thank you for opening this issue. In order to confirm it, we'll have to reproduce it.
As explained in the bug report template, please fork the following CodeSandbox and repeat your issue on it:

https://codesandbox.io/s/github/marmelab/react-admin/tree/next/examples/simple

This is the simplest way to confirm a bug is related to the React Admin codebase.

@fzaninotto
Copy link
Member

fzaninotto commented Nov 4, 2019

What does "../core did not have types should be" mean? When you mean "some files fail", what does actually fail, and what's the error message? also, you mention 2 separate versions in your description, which one are you using?

@tdeo
Copy link
Contributor

tdeo commented Nov 4, 2019

I'm running into a similar issue when using a "legacy" dataProvider, it seems that the bug was introduced in dccc3cb, and since then this import is not resolving properly dccc3cb#diff-d2b6c4d5acf1bd4486f924173f33fc4cR11

I also noticed that this for me only happens in react-scripts dev mode and not once build.

Here is a codesandbox illustrating the issue: https://codesandbox.io/s/optimistic-frog-mr8lf

@fzaninotto
Copy link
Member

Thanks, I managed to reproduce the issue. I'm Investigating.

@fzaninotto
Copy link
Member

fixed by #3927

@anewcoder1992
Copy link
Author

I'm running into a similar issue when using a "legacy" dataProvider, it seems that the bug was introduced in dccc3cb, and since then this import is not resolving properly dccc3cb#diff-d2b6c4d5acf1bd4486f924173f33fc4cR11

I also noticed that this for me only happens in react-scripts dev mode and not once build.

Here is a codesandbox illustrating the issue: https://codesandbox.io/s/optimistic-frog-mr8lf

tdeo thank you for reproduce it ,same error with me .

@anewcoder1992
Copy link
Author

What does "../core did not have types should be" mean? When you mean "some files fail", what does actually fail, and what's the error message? also, you mention 2 separate versions in your description, which one are you using?

@fzaninotto sorry , i did not provide a clear description.anyway ,thank your attention.

@anewcoder1992
Copy link
Author

fixed by #3927
have you publish your fix @fzaninotto
can i upgrade package to beta.5 now?
thanks!

@fzaninotto
Copy link
Member

no, you'll have to wait until it's published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants