-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Deprecate DisabledInput #3518
Comments
I agree. We should even remove it completely from 3.0 instead of deprecating it. |
Do you mean we should remove all other deprecated components (LongTextInput for example)? |
Fixed by #3549 |
@djhi @fzaninotto Does the |
in https://react-admin.com/docs/en/tutorial.html, the example still use DisabledInput and LongTextInput . that causes confusion for beginner. |
@ouonet You've read the wrong documentation. react-admin.com is not owned by the core team, and contains outdated documentation. The correct documentation, hosted at https://marmelab.com/react-admin/Tutorial.html, does not contain |
Following the review from @Kmaschta in #3515, we think the
DisabledInput
should be deprecated/removed.We can make almost any of the existing inputs disabled by setting either their
disabled
orreadonly
prop.We are binding a TextInput to the record value but are just not passing the event handlers. This results in an unresponsive text input, which is weird and probably confusing for people using screen readers as nothing indicates this input is readonly/disabled
The text was updated successfully, but these errors were encountered: