Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Deprecate DisabledInput #3518

Closed
djhi opened this issue Aug 13, 2019 · 6 comments
Closed

[RFC] Deprecate DisabledInput #3518

djhi opened this issue Aug 13, 2019 · 6 comments

Comments

@djhi
Copy link
Collaborator

djhi commented Aug 13, 2019

Following the review from @Kmaschta in #3515, we think the DisabledInput should be deprecated/removed.

  1. We can make almost any of the existing inputs disabled by setting either their disabled or readonly prop.

  2. We are binding a TextInput to the record value but are just not passing the event handlers. This results in an unresponsive text input, which is weird and probably confusing for people using screen readers as nothing indicates this input is readonly/disabled

@djhi djhi added this to the 3.0.0 milestone Aug 13, 2019
@fzaninotto
Copy link
Member

I agree. We should even remove it completely from 3.0 instead of deprecating it.

@djhi
Copy link
Collaborator Author

djhi commented Aug 17, 2019

Do you mean we should remove all other deprecated components (LongTextInput for example)?

@fzaninotto
Copy link
Member

Fixed by #3549

@Kunnu01
Copy link
Contributor

Kunnu01 commented Aug 22, 2019

@djhi @fzaninotto Does the LongTextInput needs to be removed? Should I work on it?

@fzaninotto fzaninotto removed this from the 3.0.0 milestone Aug 23, 2019
@ouonet
Copy link

ouonet commented Apr 5, 2020

in https://react-admin.com/docs/en/tutorial.html, the example still use DisabledInput and LongTextInput . that causes confusion for beginner.

@fzaninotto
Copy link
Member

@ouonet You've read the wrong documentation. react-admin.com is not owned by the core team, and contains outdated documentation. The correct documentation, hosted at https://marmelab.com/react-admin/Tutorial.html, does not contain <DisabledInput> or <LongTextInput>. Please update your bookmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants