Don't display approver message for non apporover on removing a member

etCoderDysto · etCoderDysto · commit 5c2d55a76cc3 · 2024-07-22T11:05:02.000+03:00
diff --git a/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx b/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx
@@ -71,7 +71,7 @@ function WorkspaceMemberDetailsPage({personalDetails, policy, route}: WorkspaceM
     const confirmModalPrompt = useMemo(() => {
         const isApprover = Member.isApprover(policy, accountID);
         if (!isApprover) {
-            translate('workspace.people.removeMemberPrompt', {memberName: displayName});
+            return translate('workspace.people.removeMemberPrompt', {memberName: displayName});
         }
         return translate('workspace.people.removeMembersWarningPrompt', {memberName: displayName, ownerName: policyOwnerDisplayName});
     }, [accountID, policy, displayName, policyOwnerDisplayName, translate]);

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ function WorkspaceMemberDetailsPage({personalDetails, policy, route}: WorkspaceM`
`71`	`71`	`const confirmModalPrompt = useMemo(() => {`
`72`	`72`	`const isApprover = Member.isApprover(policy, accountID);`
`73`	`73`	`if (!isApprover) {`
`74`		`- translate('workspace.people.removeMemberPrompt', {memberName: displayName});`
	`74`	`+ return translate('workspace.people.removeMemberPrompt', {memberName: displayName});`
`75`	`75`	`}`
`76`	`76`	`return translate('workspace.people.removeMembersWarningPrompt', {memberName: displayName, ownerName: policyOwnerDisplayName});`
`77`	`77`	`}, [accountID, policy, displayName, policyOwnerDisplayName, translate]);`