Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Syntax error breaks Node ^4.0.0 (active LTS) support #5

Closed
nickserv opened this issue Nov 7, 2016 · 3 comments
Closed

Comments

@nickserv
Copy link

nickserv commented Nov 7, 2016

An update to marcosc-async introduced the spread (...) syntax, which isn't supported in Node ^4.0.0 without the --harmony flag. This causes Node 4 to break with this package. I almost created an issue on marcosc-async, but I thought it would be less confusing here since this package has Node >=4 in engines while marcosc-async doesn't define engines.

Example failing build: https://travis-ci.org/litixsoft/karma-detect-browsers/jobs/173932752

Possible Solutions

  • Set engines to Node >=5
  • Publish a new release of marcosc-async that's compatible with Node 4 syntax and depend on that in this package (ideal solution in my opinion, since it's still an active LTS version)
@nickserv nickserv changed the title Regression: Syntax error in marcosc-async breaks Node ^4.0.0 (active LTS) support Regression: Syntax error breaks Node ^4.0.0 (active LTS) support Nov 7, 2016
@marcoscaceres
Copy link
Owner

@nickmccurdy, thanks for reporting, just fixed marcosc-async to work with Node 4.0 and above. Added engines member to the package, as suggested.

@marcoscaceres
Copy link
Owner

Should be fixed now.... please reopen if still broken.

@nickserv
Copy link
Author

nickserv commented Nov 9, 2016

Thanks, this fixes warnings in karma-detect-browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants