Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan 2.0 #17

Merged
merged 4 commits into from
Nov 28, 2024
Merged

PHPStan 2.0 #17

merged 4 commits into from
Nov 28, 2024

Conversation

olekans
Copy link
Contributor

@olekans olekans commented Nov 21, 2024

Hi!

I’m adding support for PHPStan 2.0 and removing support for older PHP versions.

@olekans olekans marked this pull request as ready for review November 21, 2024 15:53
@olekans
Copy link
Contributor Author

olekans commented Nov 25, 2024

Hi @marc-mabe! How are you? Will you find a moment to take a look at this PR?

@marc-mabe
Copy link
Owner

Hi @olekans,
This project isn't high prio for me anymore but I'll try to give it some time within the next week

@olekans olekans requested a review from marc-mabe November 28, 2024 10:19
@olekans olekans requested a review from marc-mabe November 28, 2024 13:19
@marc-mabe
Copy link
Owner

Great 🎉

Thank you @olekans

Please give me a little to think about what else should be in a new major release.

@marc-mabe marc-mabe merged commit 79ea7e3 into marc-mabe:master Nov 28, 2024
12 checks passed
@olekans olekans deleted the phpstan-2-0 branch November 28, 2024 14:00
@olekans
Copy link
Contributor Author

olekans commented Dec 9, 2024

Hi @marc-mabe!

Could you let me know what's going on with the new release? I need to know because I'm holding off on a PR in the project. If you can't create a new tag, I'll have to rely on a fork (which I really don't want to do :/)

Maybe I can help you with this somehow? Let me know if there's anything I can do!

@marc-mabe
Copy link
Owner

HI @olekans, Just did some minor cleanup - new major release is created now 🎉
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants