Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename css class #5

Merged
merged 3 commits into from
Jul 4, 2021
Merged

Rename css class #5

merged 3 commits into from
Jul 4, 2021

Conversation

aprilmay
Copy link

@aprilmay aprilmay commented Jul 4, 2021

Proposed fix for #4

@HarelM
Copy link
Collaborator

HarelM commented Jul 4, 2021

Thanks! Can you change the min version of maplibre dependency as well?

@aprilmay
Copy link
Author

aprilmay commented Jul 4, 2021

Thanks to you for this project :)
I updated my branch, it seems that this PR includes this other update. Is that enough?

@HarelM
Copy link
Collaborator

HarelM commented Jul 4, 2021

I think it's also missing here:

ngx-maplibre-gl/projects/ngx-maplibre-gl/package.json

Line 25 in e217b68

"maplibre-gl": ">= 1.14.0",

@aprilmay
Copy link
Author

aprilmay commented Jul 4, 2021

Right, good catch. Pushed another update.

@HarelM HarelM merged commit f327846 into maplibre:master Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprilmay @HarelM