Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaddingOptions causes the horizon & sky to misalign #5465

Open
Ryan-Maughan opened this issue Feb 5, 2025 · 1 comment
Open

PaddingOptions causes the horizon & sky to misalign #5465

Ryan-Maughan opened this issue Feb 5, 2025 · 1 comment
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed

Comments

@Ryan-Maughan
Copy link

It appears that adding PaddingOptions to the jumpTo function causes the horizon & sky to misalign when the top & bottom values do not match.
When the padding.top > padding.bottom a gap appears.
When the padding.top < padding.bottom they are poorly blended.

maplibre-gl-js version: 5.1.0

browser: Microsoft Edge v132.0.2957.140

Steps to Trigger Behavior

  1. jumpTo a position with PaddingOptions set
  2. Tilt the map to the horizon to view a gap between the horizon and sky

Link to Demonstration

https://jsbin.com/jehemabigu/edit?html,output

Expected Behavior

Sky should align with the horizon when PaddingOptions are set

Actual Behavior

Sky and horizon do not align when PaddingOptions are set. Specifically when top & bottom values do not match.
Gap is created in when top > bottom
Blend is created when top < bottom

@HarelM
Copy link
Collaborator

HarelM commented Feb 5, 2025

Thanks for taking the time to report this issue!
I did a quick check, and this existed before version 5.
Probably from the initial release of the sky feature.
Feel free to try and solve this...

@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants