This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
animated scaleBy #41
Merged
animated scaleBy #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add duration argument to scaleBy & setScale * add scale center arguments to setScale * add animation to Transform::setScale
|
When zooming in, this always moves back to an intermediary state for me, like snapping to integer zoom levels or something. |
|
Hmm, that's odd. Was this during gestures or programmatic use? Also, thoughts on the render issue? I think that's still outstanding. |
|
The snapping bug was fixed in c412b8d |
This was referenced Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #30 animated
scaleBy. There is one outstanding issue described below, though.durationarguments toscaleByandsetScalesetScaleTransform::setScaleifdurationis presentThis unlocks the duration arguments added for iOS in 74f3e57.
Issues to resolve:
@kkaefer any ideas?