Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Map not centered over bottom-aligned user puck #6257

Closed
miccolis opened this issue Sep 6, 2016 · 3 comments · Fixed by #6313
Closed

Map not centered over bottom-aligned user puck #6257

miccolis opened this issue Sep 6, 2016 · 3 comments · Fixed by #6313
Assignees
Labels
bug iOS Mapbox Maps SDK for iOS navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general
Milestone

Comments

@miccolis
Copy link
Contributor

miccolis commented Sep 6, 2016

Platform: iOS
Mapbox SDK version: 3.4.0-alpha.4 (51b2033)

It's looking like we're not putting the user puck on the actual location of the user. For example:

2016-09-06 11 53 33

Has me down an alley off 15th street, but actually I'm standing right at the corner of 14th and S.

It's very easy to generate this behavior in a test app, so I'm happy to provide more screenshots.

As you move around and the POV changes the puck swings around and has a very disorienting behavior.

@boundsj boundsj added bug iOS Mapbox Maps SDK for iOS labels Sep 6, 2016
@boundsj boundsj added this to the ios-v3.4.0 milestone Sep 6, 2016
@boundsj
Copy link
Contributor

boundsj commented Sep 6, 2016

This was caused by #6216

@1ec5
Copy link
Contributor

1ec5 commented Sep 6, 2016

(For those following along at home, this is an internal testbed application we use to exercise the SDK more thoroughly than iosapp does.)

The issue is that the user puck is anchored correctly towards the bottom of the map view, but the map isn’t taking that vertical alignment into consideration when centering the map on a particular coordinate. This regression was almost certainly introduced by #6216. #4067 (comment) might be relevant to a fix.

@1ec5 1ec5 changed the title Incorrectly placed puck Map not centered over bottom-aligned user puck Sep 6, 2016
@1ec5
Copy link
Contributor

1ec5 commented Sep 6, 2016

The issue can also be seen in #4067 (comment): the user dot appears to shift between the Mapbox SF office and a location several blocks to the south just by changing the vertical alignment to MGLAnnotationVerticalAlignmentBottom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants