Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

The presence of image backed annotations should not trigger log messages #5210

Closed
boundsj opened this issue Jun 1, 2016 · 3 comments
Closed
Assignees
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS
Milestone

Comments

@boundsj
Copy link
Contributor

boundsj commented Jun 1, 2016

Once a GL sprite backed annotation is added to the map, the message [INFO] {Worker}[Sprite]: Can't find sprite named 'default_marker' is seen for every tile parse that has a UIView backed annotation in it. The message comes from this line in sprite_store.cpp but the underlying issue is that annotations that are are actually backed by UIViews are not fully understood by core implementation.

@boundsj boundsj added bug iOS Mapbox Maps SDK for iOS labels Jun 1, 2016
@jfirebaugh
Copy link
Contributor

The SDK is trying to add a point annotation with the icon property set to an empty string, thinking that that will result in a point annotation without an icon, as described here. But in fact mbgl core doesn't have a concept of "point annotation without an icon". For historical reasons, the empty string is mapped to the "default_marker" icon, and any other string that doesn't have a matching icon will result in this debug message.

I think you should find another way to implement what you need for annotation views. This isn't an intended use for the core annotations API.

@boundsj boundsj added the annotations Annotations on iOS and macOS or markers on Android label Jun 2, 2016
@boundsj
Copy link
Contributor Author

boundsj commented Jun 2, 2016

Thanks @jfirebaugh. Noting that we discussed the workaround of using a transparent image with a specific name until we nail down exactly what the true fix will be.

cc @1ec5

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jun 2, 2016
@boundsj boundsj added this to the ios-v3.3.0 milestone Jun 23, 2016
@boundsj boundsj self-assigned this Jun 23, 2016
@boundsj
Copy link
Contributor Author

boundsj commented Jun 24, 2016

This was recently fixed in #5461 for iOS and Android was already using the same same solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

3 participants