-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
629f8b3
to
d376311
Compare
@incanus @bleege @friedbunny, just a heads-up that this PR brackets |
This needs to be on beta 2. Apple finally audited MapKit for nullability with Xcode 7 and the iOS 9 SDK, and we need to be compatible. |
Looks like I’ll need to also bring over much of 54e2bb8 to satisfy a warning about invoking a non-designated initializer in |
Is this mostly from a "so it still looks like Apple" POV? Or something more drastic as to why we should hit this on the sooner side? |
Mostly from a “so it still looks like Apple” POV. But also so we can say we also audited Mapbox GL for nullability, just as Apple announced this week, and because this work has no stability implications. |
@1ec5 If you are happy with this please rebase and merge it. 🚢 |
Added some nullability qualifiers in method implementation selectors for consistency with declarations. The user dot view now has a non-zero size. Previously only its layer was sized properly. Also resolved some pedantic warnings about missing designated initializer overrides. Xcode 6.3 or above is now required for building this project.
92a6ffd
to
f463286
Compare
All the headers have been audited for nullability. This is a breaking change in the sense that Swift code written against Mapbox GL will likely fail to compile. However, Xcode will offer fix-its for every error that comes up, and the resulting code will be much less stressful (less
shouting!
) and more idiomatic.Fixes #1054.
/cc @incanus