Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit deeefd0

Browse files
committed
[core] Update gl-js; fix $id filters with GeoJSON source
1 parent bb93150 commit deeefd0

File tree

8 files changed

+11
-7
lines changed

8 files changed

+11
-7
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ mason_use(variant VERSION 1.1.4 HEADER_ONLY)
4444
mason_use(unique_resource VERSION cba309e HEADER_ONLY)
4545
mason_use(rapidjson VERSION 1.1.0 HEADER_ONLY)
4646
mason_use(boost VERSION 1.62.0 HEADER_ONLY)
47-
mason_use(geojsonvt VERSION 6.1.3 HEADER_ONLY)
47+
mason_use(geojsonvt VERSION 6.2.0 HEADER_ONLY)
4848
mason_use(supercluster VERSION 0.2.0-1 HEADER_ONLY)
4949
mason_use(kdbush VERSION 0.1.1-1 HEADER_ONLY)
5050
mason_use(earcut VERSION 0.12.1 HEADER_ONLY)

cmake/mbgl.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ add_custom_target(
7171

7272
# Run npm install for both directories, and add custom commands, and a target that depends on them.
7373
_npm_install("${CMAKE_SOURCE_DIR}" mapbox-gl-native update-submodules)
74-
_npm_install("${CMAKE_SOURCE_DIR}/mapbox-gl-js" mapbox-gl-js "${CMAKE_SOURCE_DIR}/node_modules/.mapbox-gl-native.stamp")
74+
_npm_install("${CMAKE_SOURCE_DIR}/mapbox-gl-js/test/integration" mapbox-gl-js "${CMAKE_SOURCE_DIR}/node_modules/.mapbox-gl-native.stamp")
7575
add_custom_target(
7676
npm-install ALL
7777
DEPENDS "${CMAKE_SOURCE_DIR}/node_modules/.mapbox-gl-js.stamp"

mapbox-gl-js

Submodule mapbox-gl-js updated 453 files

platform/android/scripts/generate-style-code.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const fs = require('fs');
44
const ejs = require('ejs');
5-
const spec = require('../../../mapbox-gl-js/js/style-spec').latest;
5+
const spec = require('../../../mapbox-gl-js/src/style-spec/reference/v8');
66
const _ = require('lodash');
77

88
require('../../../scripts/style-code');

platform/darwin/scripts/generate-style-code.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const cocoaConventions = require('./style-spec-cocoa-conventions-v8.json');
1111
const prefix = 'MGL';
1212
const suffix = 'StyleLayer';
1313

14-
let spec = _.merge(require('../../../mapbox-gl-js/js/style-spec').latest, require('./style-spec-overrides-v8.json'));
14+
let spec = _.merge(require('../../../mapbox-gl-js/src/style-spec/reference/v8'), require('./style-spec-overrides-v8.json'));
1515

1616
///
1717
// Temporarily IGNORE layers that are in the spec yet still not supported in mbgl core

scripts/generate-shaders.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const path = require('path');
44
const fs = require('fs');
55

6-
const inputPath = 'mapbox-gl-js/shaders';
6+
const inputPath = 'mapbox-gl-js/src/shaders';
77
const outputPath = 'src/mbgl/shaders';
88

99
require('./style-code');

scripts/generate-style-code.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const fs = require('fs');
44
const ejs = require('ejs');
5-
const spec = require('../mapbox-gl-js/js/style-spec').latest;
5+
const spec = require('../mapbox-gl-js/src/style-spec/reference/v8');
66
const colorParser = require('csscolorparser');
77

88
require('./style-code');

src/mbgl/tile/geojson_tile.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ class GeoJSONTileFeature : public GeometryTileFeature {
2525
return feature.properties;
2626
}
2727

28+
optional<FeatureIdentifier> getID() const override {
29+
return feature.id;
30+
}
31+
2832
GeometryCollection getGeometries() const override {
2933
GeometryCollection geometry = apply_visitor(ToGeometryCollection(), feature.geometry);
3034

0 commit comments

Comments
 (0)