[core] fix style parsing crash when a layer's paint property is not an object

Author: kkaefer

src/mbgl/style/conversion/layer.cpp

@@ -38,6 +38,9 @@ optional<Error> setPaintProperties(Layer& layer, const Convertible& value) {
     if (!paintValue) {
         return {};
     }
+    if (!isObject(*paintValue)) {
+        return { { "paint must be an object" } };
+    }
     return eachMember(*paintValue, [&] (const std::string& k, const Convertible& v) {
         return setPaintProperty(layer, k, v);
     });

test/fixtures/style_parser/paint-nonobject.info.json

@@ -0,0 +1,7 @@
+{
+    "default": {
+        "log": [
+            [1, "WARNING", "ParseStyle", "paint must be an object"]
+        ]
+    }
+}

test/fixtures/style_parser/paint-nonobject.style.json

@@ -0,0 +1,8 @@
+{
+  "version": 8,
+  "layers": [{
+    "id": "background",
+    "type": "background",
+    "paint": true
+  }]
+}