Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit b9702ef

Browse files
1ec5kkaefer
authored andcommitted
[macos] Renamed OS X SDK to macOS SDK
Also renamed as many references to OS X as possible to macOS in documentation.
1 parent 1e41c15 commit b9702ef

File tree

99 files changed

+199
-194
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+199
-194
lines changed

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ xcuserdata
2424
/platform/ios/benchmark/assets/glyphs/DIN*
2525
/platform/ios/benchmark/assets/tiles/mapbox.mapbox-terrain-v2,mapbox.mapbox-streets-v6
2626
**/token
27-
/platform/osx/osx.xcworkspace/xcshareddata/osx.xcscmblueprint
27+
/platform/macos/macos.xcworkspace/xcshareddata/macos.xcscmblueprint

.ycm_extra_conf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
compilation_database_folders = [
4040
'build/linux-x86_64/Debug',
41-
'build/osx/Debug',
41+
'build/macos/Debug',
4242
]
4343

4444
subprocess.call(['make compdb'], shell=True)

ARCHITECTURE.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ This document aims to outline at a high level the various parts that make up map
22

33
# Repository structure
44

5-
mapbox-gl-native uses a monolithic that houses both core C++ code and code that wraps the C++ core with SDKs for Android, iOS, OS X, Node.js, and Qt. A "monorepo" allows us to:
5+
mapbox-gl-native uses a monolithic that houses both core C++ code and code that wraps the C++ core with SDKs for Android, iOS, macOS, Node.js, and Qt. A "monorepo" allows us to:
66

77
* Make changes to the core API and SDKs simultaneously, ensuring no platform falls behind.
88
* Ensure that core changes do not inadvertently break SDK tests.
@@ -42,7 +42,7 @@ We track mason dependencies for a given platform in the file `platform/<platform
4242

4343
Outside of the core C++ static library, platform SDKs typically rely on platform-native build tooling to complete the job.
4444

45-
* For iOS and OS X this means Xcode and the xcodebuild command line tool.
45+
* For iOS and macOS this means Xcode and the xcodebuild command line tool.
4646
* For Android, Gradle and Android Studio.
4747
* For Qt, `qmake`.
4848

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ Each Mapbox GL Native SDK has a separate changelog that highlights changes relev
44

55
* [Mapbox Android SDK](platform/android/CHANGELOG.md)
66
* [Mapbox iOS SDK](platform/ios/CHANGELOG.md)
7-
* [Mapbox OS X SDK](platform/osx/CHANGELOG.md)
7+
* [Mapbox macOS SDK](platform/macos/CHANGELOG.md)
88
* [node-mapbox-gl-native](platform/node/CHANGELOG.md)

CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ If you want to contribute code:
1111
1. Pull requests are gladly accepted. If there are any changes that developers using one of the GL SDKs should be aware of, please update the **master** section of the relevant changelog(s):
1212
* [Mapbox Android SDK](platform/android/CHANGELOG.md)
1313
* [Mapbox iOS SDK](platform/ios/CHANGELOG.md)
14-
* [Mapbox OS X SDK](platform/osx/CHANGELOG.md)
14+
* [Mapbox macOS SDK](platform/macos/CHANGELOG.md)
1515
* [node-mapbox-gl-native](platform/node/CHANGELOG.md)
1616

17-
1. Prefix your commit messages with the platform(s) your changes affect: `[core]`, `[android]`, `[ios]`, `[osx]`, `[node]`, or `[qt]`.
17+
1. Prefix your commit messages with the platform(s) your changes affect: `[core]`, `[android]`, `[ios]`, `[macos]`, `[node]`, or `[qt]`.
1818

1919
# Code of conduct
2020
Everyone is invited to participate in Mapbox’s open source projects and public discussions: we want to create a welcoming and friendly environment. Harassment of participants or other unethical and unprofessional behavior will not be tolerated in our spaces. The [Contributor Covenant](http://contributor-covenant.org) applies to all projects under the Mapbox organization and we ask that you please read [the full text](http://contributor-covenant.org/version/1/2/0/).

INSTALL.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ dependencies:
3737

3838
- [`libcurl`](http://curl.haxx.se/libcurl/) (depends on OpenSSL)
3939

40-
### Additional Dependencies for OS X
40+
### Additional Dependencies for macOS
4141

4242
- Apple Command Line Tools (available at [Apple Developer](https://developer.apple.com/downloads))
4343
- [Homebrew](http://brew.sh)
@@ -50,7 +50,7 @@ See the relevant SDK documentation for next steps:
5050

5151
* [Mapbox Android SDK](platform/android/)
5252
* [Mapbox iOS SDK](platform/ios/)
53-
* [Mapbox OS X SDK](platform/osx/)
53+
* [Mapbox macOS SDK](platform/macos/)
5454
* [Mapbox Qt SDK](platform/qt/)
5555
* [Mapbox GL Native on Linux](platform/linux/)
5656
* [node-mapbox-gl-native](platform/node/)

Makefile

+37-37
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export BUILDTYPE ?= Debug
22

33
ifeq ($(shell uname -s), Darwin)
4-
HOST_PLATFORM = osx
4+
HOST_PLATFORM = macos
55
export JOBS ?= $(shell sysctl -n hw.ncpu)
66
else ifeq ($(shell uname -s), Linux)
77
HOST_PLATFORM = linux
@@ -37,54 +37,54 @@ CONFIG_DEPENDENCIES = .mason/mason configure
3737
# files are added or removed.
3838
GYP_DEPENDENCIES = mbgl.gypi test/test.gypi benchmark/benchmark.gypi bin/*.gypi $(shell find src include -type d) node_modules
3939

40-
#### OS X targets ##############################################################
40+
#### macOS targets ##############################################################
4141

42-
OSX_OUTPUT_PATH = build/osx
43-
OSX_PROJ_PATH = $(OSX_OUTPUT_PATH)/platform/osx/platform.xcodeproj
44-
OSX_WORK_PATH = platform/osx/osx.xcworkspace
45-
OSX_USER_DATA_PATH = $(OSX_WORK_PATH)/xcuserdata/$(USER).xcuserdatad
42+
MACOS_OUTPUT_PATH = build/macos
43+
MACOS_PROJ_PATH = $(MACOS_OUTPUT_PATH)/platform/macos/platform.xcodeproj
44+
MACOS_WORK_PATH = platform/macos/macos.xcworkspace
45+
MACOS_USER_DATA_PATH = $(MACOS_WORK_PATH)/xcuserdata/$(USER).xcuserdatad
4646

47-
$(OSX_OUTPUT_PATH)/config.gypi: platform/osx/scripts/configure.sh $(CONFIG_DEPENDENCIES)
48-
./configure $< $@ osx
47+
$(MACOS_OUTPUT_PATH)/config.gypi: platform/macos/scripts/configure.sh $(CONFIG_DEPENDENCIES)
48+
./configure $< $@ macos
4949

50-
$(OSX_OUTPUT_PATH)/mbgl.xcconfig: $(OSX_OUTPUT_PATH)/config.gypi
50+
$(MACOS_OUTPUT_PATH)/mbgl.xcconfig: $(MACOS_OUTPUT_PATH)/config.gypi
5151
./scripts/export-xcconfig.py $< $@
5252

53-
$(OSX_PROJ_PATH): platform/osx/platform.gyp $(OSX_OUTPUT_PATH)/config.gypi $(OSX_OUTPUT_PATH)/mbgl.xcconfig $(GYP_DEPENDENCIES)
54-
$(GYP) -f xcode --generator-output=$(OSX_OUTPUT_PATH) $<
53+
$(MACOS_PROJ_PATH): platform/macos/platform.gyp $(MACOS_OUTPUT_PATH)/config.gypi $(MACOS_OUTPUT_PATH)/mbgl.xcconfig $(GYP_DEPENDENCIES)
54+
$(GYP) -f xcode --generator-output=$(MACOS_OUTPUT_PATH) $<
5555

56-
osx: $(OSX_PROJ_PATH)
56+
macos: $(MACOS_PROJ_PATH)
5757
set -o pipefail && xcodebuild \
58-
-derivedDataPath $(OSX_OUTPUT_PATH) \
58+
-derivedDataPath $(MACOS_OUTPUT_PATH) \
5959
-configuration $(BUILDTYPE) \
60-
-workspace $(OSX_WORK_PATH) -scheme CI build $(XCPRETTY)
60+
-workspace $(MACOS_WORK_PATH) -scheme CI build $(XCPRETTY)
6161

62-
xproj: $(OSX_PROJ_PATH) $(OSX_WORK_PATH)
63-
mkdir -p "$(OSX_USER_DATA_PATH)"
64-
cp platform/osx/WorkspaceSettings.xcsettings "$(OSX_USER_DATA_PATH)/WorkspaceSettings.xcsettings"
65-
open $(OSX_WORK_PATH)
62+
xproj: $(MACOS_PROJ_PATH) $(MACOS_WORK_PATH)
63+
mkdir -p "$(MACOS_USER_DATA_PATH)"
64+
cp platform/macos/WorkspaceSettings.xcsettings "$(MACOS_USER_DATA_PATH)/WorkspaceSettings.xcsettings"
65+
open $(MACOS_WORK_PATH)
6666

67-
test-osx: osx node_modules
68-
ulimit -c unlimited && ($(OSX_OUTPUT_PATH)/Build/Products/$(BUILDTYPE)/test & pid=$$! && wait $$pid \
67+
test-macos: macos node_modules
68+
ulimit -c unlimited && ($(MACOS_OUTPUT_PATH)/Build/Products/$(BUILDTYPE)/test & pid=$$! && wait $$pid \
6969
|| (lldb -c /cores/core.$$pid --batch --one-line 'thread backtrace all' --one-line 'quit' && exit 1))
7070
set -o pipefail && xcodebuild \
71-
-derivedDataPath $(OSX_OUTPUT_PATH) \
71+
-derivedDataPath $(MACOS_OUTPUT_PATH) \
7272
-configuration $(BUILDTYPE) \
73-
-workspace $(OSX_WORK_PATH) -scheme CI test $(XCPRETTY)
73+
-workspace $(MACOS_WORK_PATH) -scheme CI test $(XCPRETTY)
7474

75-
xpackage: $(OSX_PROJ_PATH)
76-
SYMBOLS=$(SYMBOLS) ./platform/osx/scripts/package.sh
75+
xpackage: $(MACOS_PROJ_PATH)
76+
SYMBOLS=$(SYMBOLS) ./platform/macos/scripts/package.sh
7777

7878
xdocument:
79-
OUTPUT=$(OUTPUT) ./platform/osx/scripts/document.sh
79+
OUTPUT=$(OUTPUT) ./platform/macos/scripts/document.sh
8080

8181
genstrings:
82-
genstrings -u -o platform/osx/sdk/Base.lproj platform/darwin/src/*.{m,mm}
83-
genstrings -u -o platform/osx/sdk/Base.lproj platform/osx/src/*.{m,mm}
82+
genstrings -u -o platform/macos/sdk/Base.lproj platform/darwin/src/*.{m,mm}
83+
genstrings -u -o platform/macos/sdk/Base.lproj platform/macos/src/*.{m,mm}
8484
genstrings -u -o platform/ios/resources/Base.lproj platform/ios/src/*.{m,mm}
85-
-find platform/ios/resources platform/osx/sdk -path '*/Base.lproj/*.strings' -exec \
85+
-find platform/ios/resources platform/macos/sdk -path '*/Base.lproj/*.strings' -exec \
8686
textutil -convert txt -extension strings -inputencoding UTF-16 -encoding UTF-8 {} \;
87-
mv platform/osx/sdk/Base.lproj/Foundation.strings platform/darwin/resources/Base.lproj/
87+
mv platform/macos/sdk/Base.lproj/Foundation.strings platform/darwin/resources/Base.lproj/
8888

8989
#### iOS targets ##############################################################
9090

@@ -297,21 +297,21 @@ compdb-linux: platform/linux/platform.gyp $(LINUX_OUTPUT_PATH)/config.gypi
297297
deps/ninja/ninja-linux -C $(LINUX_OUTPUT_PATH)/$(BUILDTYPE) \
298298
-t compdb cc cc_s cxx objc objcxx > $(LINUX_OUTPUT_PATH)/$(BUILDTYPE)/compile_commands.json
299299

300-
compdb-osx: platform/osx/platform.gyp $(OSX_OUTPUT_PATH)/config.gypi
301-
$(GYP) -f ninja -I $(OSX_OUTPUT_PATH)/config.gypi \
302-
--generator-output=$(OSX_OUTPUT_PATH) $<
303-
deps/ninja/ninja-osx -C $(OSX_OUTPUT_PATH)/$(BUILDTYPE) \
304-
-t compdb cc cc_s cxx objc objcxx > $(OSX_OUTPUT_PATH)/$(BUILDTYPE)/compile_commands.json
300+
compdb-macos: platform/macos/platform.gyp $(MACOS_OUTPUT_PATH)/config.gypi
301+
$(GYP) -f ninja -I $(MACOS_OUTPUT_PATH)/config.gypi \
302+
--generator-output=$(MACOS_OUTPUT_PATH) $<
303+
deps/ninja/ninja-macos -C $(MACOS_OUTPUT_PATH)/$(BUILDTYPE) \
304+
-t compdb cc cc_s cxx objc objcxx > $(MACOS_OUTPUT_PATH)/$(BUILDTYPE)/compile_commands.json
305305

306306
tidy: compdb tidy-$(HOST_PLATFORM)
307307

308308
tidy-linux:
309309
deps/ninja/ninja-linux -C $(LINUX_OUTPUT_PATH)/$(BUILDTYPE) headers
310310
scripts/clang-tidy.sh $(LINUX_OUTPUT_PATH)/$(BUILDTYPE)
311311

312-
tidy-osx:
313-
deps/ninja/ninja-osx -C $(OSX_OUTPUT_PATH)/$(BUILDTYPE) headers
314-
scripts/clang-tidy.sh $(OSX_OUTPUT_PATH)/$(BUILDTYPE)
312+
tidy-macos:
313+
deps/ninja/ninja-macos -C $(MACOS_OUTPUT_PATH)/$(BUILDTYPE) headers
314+
scripts/clang-tidy.sh $(MACOS_OUTPUT_PATH)/$(BUILDTYPE)
315315

316316
#### Miscellaneous targets #####################################################
317317

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ A library for embedding interactive, customizable vector maps into native applic
44

55
## The Mapbox GL ecosystem
66

7-
This repository hosts the cross-platform Mapbox GL Native library, plus convenient SDKs for several platforms. The cross-platform library comes with a [GLFW](https://github.com/glfw/glfw)-based demo application for Ubuntu Linux and OS X. The SDKs target the usual languages on their respective platforms:
7+
This repository hosts the cross-platform Mapbox GL Native library, plus convenient SDKs for several platforms. The cross-platform library comes with a [GLFW](https://github.com/glfw/glfw)-based demo application for Ubuntu Linux and macOS. The SDKs target the usual languages on their respective platforms:
88

99
SDK | Languages | Build status
1010
----|-----------|-------------
1111
[Mapbox GL Native](INSTALL.md) | C++14 | [![Travis](https://travis-ci.org/mapbox/mapbox-gl-native.svg?branch=master)](https://travis-ci.org/mapbox/mapbox-gl-native/builds) [![Coverage Status](https://coveralls.io/repos/github/mapbox/mapbox-gl-native/badge.svg?branch=master)](https://coveralls.io/github/mapbox/mapbox-gl-native?branch=master)
1212
[Mapbox Android SDK](platform/android/) | Java | [![Bitrise](https://www.bitrise.io/app/79cdcbdc42de4303.svg?token=_InPF8bII6W7J6kFr-L8QQ&branch=master)](https://www.bitrise.io/app/79cdcbdc42de4303)
1313
[Mapbox iOS SDK](platform/ios/) | Objective-C or Swift | [![Bitrise](https://www.bitrise.io/app/7514e4cf3da2cc57.svg?token=OwqZE5rSBR9MVWNr_lf4sA&branch=master)](https://www.bitrise.io/app/7514e4cf3da2cc57)
14-
[Mapbox OS X SDK](platform/osx/) | Objective-C or Swift | [![Bitrise](https://www.bitrise.io/app/155ef7da24b38dcd.svg?token=4KSOw_gd6WxTnvGE2rMttg&branch=master)](https://www.bitrise.io/app/155ef7da24b38dcd)
15-
[node-mapbox-gl-native](platform/node/) | Node.js | [![Linux](https://travis-ci.org/mapbox/mapbox-gl-native.svg?branch=master)](https://travis-ci.org/mapbox/mapbox-gl-native/builds) [![OS X](https://www.bitrise.io/app/55e3a9bf71202106.svg?token=5qf5ZUcKVN3LDnHhW7rO0w)](https://www.bitrise.io/app/55e3a9bf71202106)
14+
[Mapbox macOS SDK](platform/macos/) | Objective-C or Swift | [![Bitrise](https://www.bitrise.io/app/155ef7da24b38dcd.svg?token=4KSOw_gd6WxTnvGE2rMttg&branch=master)](https://www.bitrise.io/app/155ef7da24b38dcd)
15+
[node-mapbox-gl-native](platform/node/) | Node.js | [![Linux](https://travis-ci.org/mapbox/mapbox-gl-native.svg?branch=master)](https://travis-ci.org/mapbox/mapbox-gl-native/builds) [![macOS](https://www.bitrise.io/app/55e3a9bf71202106.svg?token=5qf5ZUcKVN3LDnHhW7rO0w)](https://www.bitrise.io/app/55e3a9bf71202106)
1616
[Mapbox Qt SDK](platform/qt) | C++03 | [![Travis](https://travis-ci.org/mapbox/mapbox-gl-native.svg?branch=master)](https://travis-ci.org/mapbox/mapbox-gl-native/builds) [![Bitrise](https://www.bitrise.io/app/96cfbc97e0245c22.svg?token=GxsqIOGPXhn0F23sSVSsYA&branch=master)](https://www.bitrise.io/app/96cfbc97e0245c22)
1717

1818
Additional Mapbox GL Native–based libraries are developed outside of this repository:

bin/offline.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
set -e
44
set -o pipefail
55

6-
OFFLINE=./build/osx/Release/mbgl-offline
6+
OFFLINE=./build/macos/Release/mbgl-offline
77

88
# Barcelona
99
$OFFLINE --north 41.4664 --west 2.0407 --south 41.2724 --east 2.2680 --output barcelona.db

configure

+4
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ OUTPUT_FILE=$2
77
export MASON_PLATFORM=$3
88
export MASON_PLATFORM_VERSION=${4:-}
99

10+
if [ "${MASON_PLATFORM}" = "macos" ]; then
11+
export MASON_PLATFORM=osx
12+
fi
13+
1014
if [ -z ${INPUT_FILE} ]; then
1115
abort 'You need to specify an input path for the configure.sh file'
1216
fi
File renamed without changes.

platform/android/CONTRIBUTING_OSX.md platform/android/CONTRIBUTING_MACOS.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Contributing to the Android SDK on OS X
1+
# Contributing to the Android SDK on macOS
22

33
Install Oracle JDK 7+ and Android Studio:
44

platform/android/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ A library based on [Mapbox GL Native](../../README.md) for embedding interactive
1515
Building the SDK yourself requires [a number of dependencies and steps](../../INSTALL.md) that are unnecessary for developing production applications.
1616

1717
* [Contributing on Linux](CONTRIBUTING_LINUX.md)
18-
* [Contributing on OS X](CONTRIBUTING_OSX.md)
18+
* [Contributing on macOS](CONTRIBUTING_MACOS.md)
1919

2020
### Setting up the Android emulator
2121

platform/darwin/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Darwin
22

33
The code in the Darwin platform targets Apple platforms but is not specific
4-
to iOS or OS X. This code is not distributed as an SDK in itself, but is required
4+
to iOS or macOS. This code is not distributed as an SDK in itself, but is required
55
by the [Mapbox iOS SDK](https://github.com/mapbox/mapbox-gl-native/tree/master/platform/ios)
6-
and [Mapbox OS X SDK](https://github.com/mapbox/mapbox-gl-native/tree/master/platform/osx).
6+
and [Mapbox macOS SDK](https://github.com/mapbox/mapbox-gl-native/tree/master/platform/macos).
77

88
These files depend on the Foundation and Core Foundation frameworks but do not
9-
depend on iOS- or OS X–specific frameworks, such as UIKit or AppKit. Any
9+
depend on iOS- or macOS–specific frameworks, such as UIKit or AppKit. Any
1010
non-cross-platform code is guarded by TargetConditionals.h macros.

platform/darwin/src/http_file_source.mm

+2-2
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ void cancel() {
130130
}
131131
}
132132

133-
// Avoid %s here because it inserts hidden bidirectional markers on OS X when the system
133+
// Avoid %s here because it inserts hidden bidirectional markers on macOS when the system
134134
// language is set to a right-to-left language.
135135
[userAgentComponents addObject:[NSString stringWithFormat:@"MapboxGL/%@ (%@)",
136136
CFSTR(MBGL_VERSION_STRING), CFSTR(MBGL_VERSION_REV)]];
@@ -139,7 +139,7 @@ void cancel() {
139139
#if TARGET_OS_IPHONE
140140
systemName = @"iOS";
141141
#elif TARGET_OS_MAC
142-
systemName = @"OS X";
142+
systemName = @"macOS";
143143
#elif TARGET_OS_WATCH
144144
systemName = @"watchOS";
145145
#elif TARGET_OS_TV

platform/ios/DEVELOPING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This document explains how to build the Mapbox iOS SDK from source. It is intend
44

55
## Requirements
66

7-
The Mapbox iOS SDK and iosapp demo application build against the iOS 7.0 SDK. The SDK is intended to run on iOS 7.0 and above, while iosapp is intended to run on iOS 8.0 and above due to the use of a dynamic framework. Both require Xcode on a computer running OS X.
7+
The Mapbox iOS SDK and iosapp demo application build against the iOS 7.0 SDK. The SDK is intended to run on iOS 7.0 and above, while iosapp is intended to run on iOS 8.0 and above due to the use of a dynamic framework. Both require Xcode on a computer running macOS.
88

99
## Building the SDK
1010

@@ -69,14 +69,14 @@ To add an Objective-C header or implementation file to the iOS SDK:
6969

7070
1. Add the file to the Headers or Compile Sources build phase, as appropriate, of both the “dynamic” and “static” targets. You can either use the Build Phases tab of the project editor or the Target Membership section of the File inspector.
7171
1. _(Optional.)_ If it’s a public header, change its visibility from Project to Public and import it in [the iOS SDK’s umbrella header](./src/Mapbox.h).
72-
1. _(Optional.)_ If the file would also be used by the OS X SDK, make sure it’s in [platform/darwin/src/](../darwin/src/), then consult [the companion OS X document](../osx/DEVELOPING.md#adding-a-source-code-file) for further instructions.
72+
1. _(Optional.)_ If the file would also be used by the macOS SDK, make sure it’s in [platform/darwin/src/](../darwin/src/), then consult [the companion macOS document](../macos/DEVELOPING.md#adding-a-source-code-file) for further instructions.
7373

7474
### Adding a resource
7575

7676
To add a resource (such as an image, SSL certificate, property list, or strings table) to the iOS SDK:
7777

7878
1. Add the header to the Copy Bundle Resources build phase of both the “dynamic” and “bundle” targets. You can either use the Build Phases tab of the project editor or the Target Membership section of the File inspector.
79-
1. _(Optional.)_ If the resource would also be used by the OS X SDK, make sure it’s in [platform/darwin/resources/](../darwin/resources/), then consult [the companion OS X document](../osx/DEVELOPING.md#adding-a-resource) for further instructions.
79+
1. _(Optional.)_ If the resource would also be used by the macOS SDK, make sure it’s in [platform/darwin/resources/](../darwin/resources/), then consult [the companion macOS document](../macos/DEVELOPING.md#adding-a-resource) for further instructions.
8080

8181
### Adding user-facing text
8282

@@ -85,11 +85,11 @@ To add or update text that the user may see in the iOS SDK:
8585
1. Make sure the implementation file imports [NSBundle+MGLAdditions.h](../darwin/src/NSBundle+MGLAdditions.h).
8686
1. Use the `NSLocalizedStringWithDefaultValue()` macro:
8787
* `key` is a unique identifier that won’t change if the user-facing text ever needs to change.
88-
* `tbl` is `Foundation` in code shared between the iOS and OS X SDKs, or `nil` otherwise.
88+
* `tbl` is `Foundation` in code shared between the iOS and macOS SDKs, or `nil` otherwise.
8989
* `bundle` is `nil`; the redefined macro looks for the SDK bundle at runtime and ignores this argument.
9090
* `val` is the English string.
9191
1. _(Optional.)_ When dealing with a number followed by a pluralized word, do not split the string. Instead, use a format string and make `val` ambiguous, like `%d file(s)`. Then pluralize for English in the appropriate [.stringsdict file](https://developer.apple.com/library/ios/documentation/MacOSX/Conceptual/BPInternational/StringsdictFileFormat/StringsdictFileFormat.html). See [platform/darwin/resources/en.lproj/Foundation.stringsdict](../darwin/resources/en.lproj/Foundation.stringsdict) for an example. Localizers should do likewise for their languages.
92-
1. Run `make genstrings` and commit any changes it makes to .strings files. The make rule also updates the OS X SDK’s strings tables.
92+
1. Run `make genstrings` and commit any changes it makes to .strings files. The make rule also updates the macOS SDK’s strings tables.
9393

9494
## Testing
9595

platform/osx/CHANGELOG.md platform/macos/CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
# Changelog for Mapbox OS X SDK
1+
# Changelog for Mapbox macOS SDK
22

33
## master
44

5+
* Renamed the SDK to the Mapbox macOS SDK.
56
* Fixed an issue in which Mapbox.framework was nested inside another folder named Mapbox.framework. ([#4998](https://github.com/mapbox/mapbox-gl-native/pull/4998))
67
* Added methods to MGLMapView for obtaining the underlying map data rendered by the current style, along with additional classes to represent complex geometry in that data. ([#5110](https://github.com/mapbox/mapbox-gl-native/pull/5110))
78
* An MGLPolygon can now have interior polygons, representing holes knocked out of the overall shape. ([#5110](https://github.com/mapbox/mapbox-gl-native/pull/5110))

0 commit comments

Comments
 (0)