Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit 6f708ac

Browse files
authored
[ios, macos] Update MGLMapView logo view (#8771)
* [ios, macos] Updated logo view to new Mapbox logo * [default] Updated attribution logo SVG
1 parent 42c308f commit 6f708ac

File tree

9 files changed

+95
-3
lines changed

9 files changed

+95
-3
lines changed
Loading

platform/ios/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
1414

1515
### Other changes
1616

17+
* Updated MGLMapView’s logo view to display [the new Mapbox logo](https://www.mapbox.com/blog/new-mapbox-logo/). ([#8771](https://github.com/mapbox/mapbox-gl-native/pull/8771))
1718
* Fixed a crash or console spew when MGLMapView is initialized with a frame smaller than 64 points wide by 64 points tall. ([#8562](https://github.com/mapbox/mapbox-gl-native/pull/8562))
1819
* The error passed into `-[MGLMapViewDelegate mapViewDidFailLoadingMap:withError:]` now includes a more specific description and failure reason. ([#8418](https://github.com/mapbox/mapbox-gl-native/pull/8418))
1920
* Fixed an issue where gesture recognizers associated with map view interactivity were not disabled when their related interactions were disabled. ([#8304](https://github.com/mapbox/mapbox-gl-native/pull/8304))

platform/ios/resources/mapbox.png

1.23 KB
Loading

platform/ios/resources/mapbox@2x.png

3.04 KB
Loading

platform/ios/resources/mapbox@3x.png

4.84 KB
Loading

platform/ios/src/MGLMapView.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ - (void)commonInit
466466

467467
// setup logo bug
468468
//
469-
UIImage *logo = [[MGLMapView resourceImageNamed:@"mapbox.png"] imageWithAlignmentRectInsets:UIEdgeInsetsMake(1.5, 4, 3.5, 2)];
469+
UIImage *logo = [MGLMapView resourceImageNamed:@"mapbox.png"];
470470
_logoView = [[UIImageView alloc] initWithImage:logo];
471471
_logoView.accessibilityTraits = UIAccessibilityTraitStaticText;
472472
_logoView.accessibilityLabel = NSLocalizedStringWithDefaultValue(@"LOGO_A11Y_LABEL", nil, nil, @"Mapbox", @"Accessibility label");

platform/macos/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
### Other changes
1212

13+
* Updated MGLMapView’s logo view to display [the new Mapbox logo](https://www.mapbox.com/blog/new-mapbox-logo/). ([#8771](https://github.com/mapbox/mapbox-gl-native/pull/8771))
1314
* Fixed an issue causing attribution button text to appear blue instead of black. ([#8701](https://github.com/mapbox/mapbox-gl-native/pull/8701))
1415
* Fixed a crash or console spew when MGLMapView is initialized with a frame smaller than 64 points wide by 64 points tall. ([#8562](https://github.com/mapbox/mapbox-gl-native/pull/8562))
1516
* The error passed into `-[MGLMapViewDelegate mapViewDidFailLoadingMap:withError:]` now includes a more specific description and failure reason. ([#8418](https://github.com/mapbox/mapbox-gl-native/pull/8418))

platform/macos/sdk/mapbox.pdf

22 KB
Binary file not shown.

platform/macos/src/MGLMapView.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ - (void)installLogoView {
363363
NSImage *logoImage = [[NSImage alloc] initWithContentsOfFile:
364364
[[NSBundle mgl_frameworkBundle] pathForResource:@"mapbox" ofType:@"pdf"]];
365365
// Account for the image’s built-in padding when aligning other controls to the logo.
366-
logoImage.alignmentRect = NSInsetRect(logoImage.alignmentRect, 3, 3);
366+
logoImage.alignmentRect = NSInsetRect(logoImage.alignmentRect, 0, 3);
367367
_logoView.image = logoImage;
368368
_logoView.translatesAutoresizingMaskIntoConstraints = NO;
369369
_logoView.accessibilityTitle = NSLocalizedStringWithDefaultValue(@"MAP_A11Y_TITLE", nil, nil, @"Mapbox", @"Accessibility title");

0 commit comments

Comments
 (0)