[android] - verify optional before accessing it

tobrun · tobrun · commit 690c7e585563 · 2018-03-19T13:11:03.000+01:00
diff --git a/platform/android/src/file_source.cpp b/platform/android/src/file_source.cpp
@@ -70,14 +70,16 @@ void FileSource::resume(jni::JNIEnv&) {
 
     activationCounter.value()++;
     if (activationCounter == 1) {
-       fileSource->resume();
+        fileSource->resume();
     }
 }
 
 void FileSource::pause(jni::JNIEnv&) {
-    activationCounter.value()--;
-    if (activationCounter == 0) {
-        fileSource->pause();
+    if (activationCounter) {
+        activationCounter.value()--;
+        if (activationCounter == 0) {
+            fileSource->pause();
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -70,14 +70,16 @@ void FileSource::resume(jni::JNIEnv&) {`
`70`	`70`
`71`	`71`	`activationCounter.value()++;`
`72`	`72`	`if (activationCounter == 1) {`
`73`		`- fileSource->resume();`
	`73`	`+ fileSource->resume();`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`void FileSource::pause(jni::JNIEnv&) {`
`78`		`- activationCounter.value()--;`
`79`		`- if (activationCounter == 0) {`
`80`		`- fileSource->pause();`
	`78`	`+ if (activationCounter) {`
	`79`	`+ activationCounter.value()--;`
	`80`	`+ if (activationCounter == 0) {`
	`81`	`+ fileSource->pause();`
	`82`	`+ }`
`81`	`83`	`}`
`82`	`84`	`}`
`83`	`85`