Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit 62ad689

Browse files
committed
[android] - execute notifying listeners when not idle
1 parent d7d3d2c commit 62ad689

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/CameraChangeDispatcher.java

+15-3
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,22 @@ class CameraChangeDispatcher implements MapboxMap.OnCameraMoveStartedListener, M
2525
private OnCameraMoveListener onCameraMoveListener;
2626
private OnCameraIdleListener onCameraIdleListener;
2727

28+
@Deprecated
2829
void setOnCameraMoveStartedListener(OnCameraMoveStartedListener onCameraMoveStartedListener) {
2930
this.onCameraMoveStartedListener = onCameraMoveStartedListener;
3031
}
3132

33+
@Deprecated
3234
void setOnCameraMoveCanceledListener(OnCameraMoveCanceledListener onCameraMoveCanceledListener) {
3335
this.onCameraMoveCanceledListener = onCameraMoveCanceledListener;
3436
}
3537

38+
@Deprecated
3639
void setOnCameraMoveListener(OnCameraMoveListener onCameraMoveListener) {
3740
this.onCameraMoveListener = onCameraMoveListener;
3841
}
3942

43+
@Deprecated
4044
void setOnCameraIdleListener(OnCameraIdleListener onCameraIdleListener) {
4145
this.onCameraIdleListener = onCameraIdleListener;
4246
}
@@ -46,12 +50,14 @@ public void onCameraMoveStarted(int reason) {
4650
if (!idle) {
4751
return;
4852
}
49-
5053
idle = false;
54+
55+
// deprecated API
5156
if (onCameraMoveStartedListener != null) {
5257
onCameraMoveStartedListener.onCameraMoveStarted(reason);
5358
}
5459

60+
// new API
5561
if (!onCameraMoveStartedListenerList.isEmpty()) {
5662
for (OnCameraMoveStartedListener cameraMoveStartedListener : onCameraMoveStartedListenerList) {
5763
cameraMoveStartedListener.onCameraMoveStarted(reason);
@@ -61,11 +67,13 @@ public void onCameraMoveStarted(int reason) {
6167

6268
@Override
6369
public void onCameraMove() {
70+
// deprecated API
6471
if (onCameraMoveListener != null && !idle) {
6572
onCameraMoveListener.onCameraMove();
6673
}
6774

68-
if (!onCameraMoveListenerList.isEmpty()) {
75+
// new API
76+
if (!onCameraMoveListenerList.isEmpty() && !idle) {
6977
for (OnCameraMoveListener cameraMoveListener : onCameraMoveListenerList) {
7078
cameraMoveListener.onCameraMove();
7179
}
@@ -74,11 +82,13 @@ public void onCameraMove() {
7482

7583
@Override
7684
public void onCameraMoveCanceled() {
85+
// deprecated API
7786
if (onCameraMoveCanceledListener != null && !idle) {
7887
onCameraMoveCanceledListener.onCameraMoveCanceled();
7988
}
8089

81-
if (!onCameraMoveCanceledListenerList.isEmpty()) {
90+
// new API
91+
if (!onCameraMoveCanceledListenerList.isEmpty() && !idle) {
8292
for (OnCameraMoveCanceledListener cameraMoveCanceledListener : onCameraMoveCanceledListenerList) {
8393
cameraMoveCanceledListener.onCameraMoveCanceled();
8494
}
@@ -89,10 +99,12 @@ public void onCameraMoveCanceled() {
8999
public void onCameraIdle() {
90100
if (!idle) {
91101
idle = true;
102+
// deprecated API
92103
if (onCameraIdleListener != null) {
93104
onCameraIdleListener.onCameraIdle();
94105
}
95106

107+
// new API
96108
if (!onCameraIdleListenerList.isEmpty()) {
97109
for (OnCameraIdleListener cameraIdleListener : onCameraIdleListenerList) {
98110
cameraIdleListener.onCameraIdle();

0 commit comments

Comments
 (0)