Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit 08c9406

Browse files
committed
[node] Run rendering tests on Bitrise OS X
1 parent aef1f81 commit 08c9406

File tree

5 files changed

+13
-26
lines changed

5 files changed

+13
-26
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
],
2727
"devDependencies": {
2828
"aws-sdk": "^2.2.21",
29-
"mapbox-gl-test-suite": "mapbox/mapbox-gl-test-suite#fc3f2302bfc50ac5c779d4685d3353ee4a388eb1",
29+
"mapbox-gl-test-suite": "mapbox/mapbox-gl-test-suite#1e0d988e187a6c9a7a74fa8d7feb9c66c2258123",
3030
"node-gyp": "^3.2.1",
3131
"request": "^2.67.0",
3232
"tape": "^4.2.2"

platform/default/headless_display.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ HeadlessDisplay::HeadlessDisplay() {
1616
CGLPixelFormatAttribute attributes[] = {
1717
kCGLPFAOpenGLProfile,
1818
static_cast<CGLPixelFormatAttribute>(kCGLOGLPVersion_Legacy),
19-
kCGLPFAAccelerated,
2019
static_cast<CGLPixelFormatAttribute>(0)
2120
};
2221

platform/node/bitrise.yml

+1-4
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,15 @@ workflows:
3131
inputs:
3232
- content: |-
3333
#!/bin/bash
34-
set -e
35-
set -o pipefail
3634
export TRAVIS_OS_NAME=osx
3735
export TRAVIS_TAG=$BITRISE_GIT_TAG
36+
export TRAVIS_JOB_NUMBER=$BITRISE_BUILD_NUMBER
3837
export NODE_VERSION=4
3938
export CXX=clang++
4039
export CC=clang
4140
source ./scripts/set_compiler.sh
4241
./platform/node/scripts/install.sh
43-
if command -v ccache >/dev/null 2>&1; then ccache --zero-stats ; fi
4442
./platform/node/scripts/run.sh
45-
if command -v ccache >/dev/null 2>&1; then ccache --show-stats ; fi
4643
./platform/node/scripts/after_script.sh
4744
- slack:
4845
title: Post to Slack

platform/node/scripts/after_script.sh

+9-7
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,17 @@ if [[ ${TRAVIS_TAG} == node-v${PACKAGE_JSON_VERSION} ]]; then
3636
fi
3737
fi
3838

39-
if [[ ${TRAVIS_OS_NAME} == "linux" ]] && [ ! -z "${AWS_ACCESS_KEY_ID}" ] && [ ! -z "${AWS_SECRET_ACCESS_KEY}" ] ; then
40-
# Install and add awscli to PATH for uploading the results
41-
pip install --user awscli
42-
export PATH="`python -m site --user-base`/bin:${PATH}"
39+
if [ ! -z "${AWS_ACCESS_KEY_ID}" ] && [ ! -z "${AWS_SECRET_ACCESS_KEY}" ] ; then
40+
if [[ ${TRAVIS_OS_NAME} == "linux" ]] ; then
41+
pip install --user awscli
42+
export PATH="`python -m site --user-base`/bin:${PATH}"
43+
else
44+
brew install awscli
45+
fi
4346

44-
REPO_NAME=$(basename $TRAVIS_REPO_SLUG)
4547
gzip --stdout node_modules/mapbox-gl-test-suite/render-tests/index.html | \
4648
aws s3 cp --acl public-read --content-encoding gzip --content-type text/html \
47-
- s3://mapbox/$REPO_NAME/render-tests/$TRAVIS_JOB_NUMBER/index.html
49+
- s3://mapbox/mapbox-gl-native/render-tests/$TRAVIS_JOB_NUMBER/index.html
4850

49-
echo http://mapbox.s3.amazonaws.com/$REPO_NAME/render-tests/$TRAVIS_JOB_NUMBER/index.html
51+
echo http://mapbox.s3.amazonaws.com/mapbox-gl-native/render-tests/$TRAVIS_JOB_NUMBER/index.html
5052
fi

platform/node/scripts/run.sh

+2-13
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,9 @@ source ./platform/${TRAVIS_OS_NAME}/scripts/setup.sh
77

88
BUILDTYPE=${BUILDTYPE:-Release}
99

10-
################################################################################
11-
# Build
12-
################################################################################
13-
1410
source ~/.nvm/nvm.sh
1511
nvm use $NODE_VERSION
1612
npm install --build-from-source
1713

18-
################################################################################
19-
# Test
20-
################################################################################
21-
22-
# https://github.com/mapbox/mapbox-gl-native/issues/2150
23-
if [[ ${TRAVIS_OS_NAME} == "linux" ]]; then
24-
npm test
25-
npm run test-suite
26-
fi
14+
npm test
15+
npm run test-suite

0 commit comments

Comments
 (0)