Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer events for interaction in supported browsers #8021

Closed
joedjc opened this issue Mar 12, 2019 · 4 comments
Closed

Use pointer events for interaction in supported browsers #8021

joedjc opened this issue Mar 12, 2019 · 4 comments

Comments

@joedjc
Copy link

joedjc commented Mar 12, 2019

mapbox-gl-js version: 0.51.3

browser: Microsoft Edge 44.17763.1.0

Steps to Trigger Behavior

  1. Scroll the map using a precision touchpad laptop (e.g. Dell XPS, HP Spectre etc.)

Expected Behavior

Map should zoom on scroll

Actual Behavior

Map doesn't scroll.

We believe this is related to this Microsoft Edge issue https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7134034/

However, we noticed that Google Maps, Leaflet etc do seem to work so there must be a way of addressing the issue. Microsoft are re-building Edge as a Chronium based browser which may fix it - but it's going to be some time before it's in common use.

We'd be interested to get your view on whether there's a way to make this work in current versions of Edge?

@lukejack
Copy link

I'm able to reproduce this issue on a Lenovo Thinkpad

@mourner
Copy link
Member

mourner commented Mar 14, 2019

Thanks for the report! Wow, that MS issue thread is impressive. So, as far as I understand, the only way to fix this for us would be to switch from wheel/mouse events to pointer-events in supported browsers (currently all modern browsers except Safari for iOS/macOS & Firefox for Android).

This can provide additional benefits — potentially more precise control, better input performance, better compatibility with various unconventional input devices. However, it might be a significant lift. We should definitely look into this.

@mourner
Copy link
Member

mourner commented Mar 14, 2019

Related issue that would also get fixed if we go with pointer events: #1928

@chloekraw chloekraw changed the title Scrolling with precision touchpad in Edge does not zoom Use pointer events for interaction in supported browsers May 12, 2019
@asheemmamoowala
Copy link
Contributor

Closing as Edge has switched over to a different rendering engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants