chore: Setup biome linting (#173)

Author: manzt

.changeset/kind-cherries-explain.md

@@ -0,0 +1,9 @@
+---
+"@zarrita/typedarray": patch
+"@zarrita/indexing": patch
+"@zarrita/ndarray": patch
+"@zarrita/storage": patch
+"@zarrita/core": patch
+---
+
+Remove use of public any from API in favor of unknown

biome.json

@@ -6,7 +6,14 @@
 	"linter": {
 		"enabled": true,
 		"rules": {
-			"recommended": true
+			"recommended": true,
+			"style": {
+				"useConst": "off",
+				"noParameterAssign": "off"
+			},
+			"suspicious": {
+				"noShadowRestrictedNames": "off"
+			}
 		}
 	},
 	"files": {

package.json

@@ -5,7 +5,7 @@
 		"clean": "pnpm --recursive exec rm -rf dist",
 		"test": "vitest --api",
 		"format": "biome format .",
-		"lint": "echo \"TODO: Add linting\"",
+		"lint": "biome lint .",
 		"publint": "pnpm --recursive --filter=\"./packages/**\" exec publint"
 	},
 	"devDependencies": {

packages/core/__tests__/consolidated.test.ts

@@ -51,6 +51,7 @@ describe("withConsolidated", () => {
 	it("loads chunk data from underlying store", async () => {
 		let root = path.join(__dirname, "../../../fixtures/v2/data.zarr");
 		let store = await withConsolidated(new FileSystemStore(root));
+		// biome-ignore lint/style/noNonNullAssertion: Fine for a test
 		let entry = store
 			.contents()
 			.find((x) => x.path === "/3d.chunked.mixed.i2.C")!;
@@ -102,7 +103,7 @@ describe("withConsolidated", () => {
 		let try_open = () => withConsolidated(new FileSystemStore(root));
 		await expect(try_open).rejects.toThrowError(NodeNotFoundError);
 		await expect(try_open).rejects.toThrowErrorMatchingInlineSnapshot(
-			`[NodeNotFoundError: Node not found: v2 consolidated metadata]`,
+			"[NodeNotFoundError: Node not found: v2 consolidated metadata]",
 		);
 	});
 });

packages/core/__tests__/create.test.ts

@@ -10,6 +10,7 @@ test("create root group", async () => {
 	expect(grp.attrs).toStrictEqual(attributes);
 	expect(grp.store.has("/zarr.json")).true;
 	expect(
+		// biome-ignore lint/style/noNonNullAssertion: we know it's there
 		json_decode_object(grp.store.get("/zarr.json")!),
 	).toMatchInlineSnapshot(`
 		{
@@ -38,6 +39,7 @@ test("create array", async () => {
 	expect(a.chunks).toStrictEqual([2, 5]);
 	expect(a.attrs).toStrictEqual(attributes);
 	expect(
+		// biome-ignore lint/style/noNonNullAssertion: we know it's there
 		json_decode_object(h.store.get("/arthur/dent/zarr.json")!),
 	).toMatchInlineSnapshot(`
 		{

packages/core/__tests__/hierarchy.test.ts

@@ -63,7 +63,7 @@ describe("Array", () => {
 	});
 
 	test("Array.is", () => {
-		let arr = new Array(new Map(), "/", array_metadata as any);
+		let arr = new Array(new Map(), "/", array_metadata as ArrayMetadata);
 		expectTypeOf(arr.dtype).toMatchTypeOf<DataType>();
 		if (arr.is("bigint")) {
 			expectTypeOf(arr.dtype).toMatchTypeOf<BigintDataType>();

packages/core/__tests__/json2.test.ts

@@ -90,7 +90,7 @@ describe("JsonCodec", () => {
 		expect(() => jsonCodec.encode(chunk)).toThrowError();
 	});
 	test("throws on encode with check_circular and circular reference", () => {
-		let data: any[] = ["A", null];
+		let data: unknown[] = ["A", null];
 		data[1] = data;
 		const chunk = {
 			data,
@@ -102,7 +102,7 @@ describe("JsonCodec", () => {
 	});
 	test("supports !allow_nan", () => {
 		const chunk = {
-			data: [1, 2, NaN],
+			data: [1, 2, Number.NaN],
 			shape: [3],
 			stride: [1],
 		};
@@ -117,7 +117,7 @@ describe("JsonCodec", () => {
 		};
 		const jsonCodec = new JsonCodec({ sort_keys: true });
 		const decodedChunk = jsonCodec.decode(jsonCodec.encode(chunk));
-		expect(Object.keys(decodedChunk.data[0])).toEqual(["1", "2", "3"]);
+		expect(decodedChunk.data[0]).toEqual({ "1": 1, "2": 2, "3": 3 });
 	});
 	test("supports ensure_ascii", () => {
 		const chunk = {