Skip to content

Commit 1adea9f

Browse files
authored
🐛 revert: force native spell check until Electron issue is fixed (#464) (#472)
Signed-off-by: Marc Nuri <marc@marcnuri.com>
1 parent 87eb1f5 commit 1adea9f

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/settings/settings.spell-check.browser.mjs

-4
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ export const SpellCheckPane = ({dispatch, state}) => {
4444
checked=${useNative}
4545
onClick=${toggleProperty({dispatch, property: 'useNativeSpellChecker'})}
4646
/>
47-
<div data-testid='settings-todo-native-spell-check' style=${{'font-size': '1.1rem', 'padding-left': '0.5rem'}}>
48-
<p>NOTE: Currently, the Native Spell Checker is <strong>always</strong> used due to a bug in Electron:</p>
49-
<p><a href='https://github.com/electron/electron/issues/44336'>electron/issues/44336</a></p>
50-
</div>
5147
<${Card.Divider} />
5248
<div class='settings__dictionaries'>${
5349
Object.entries(dictionaries(state))

src/spell-check/index.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,7 @@ const getAvailableNativeDictionaries = () =>
8787
const handleGetMisspelled = async (_event, words) =>
8888
fakeRendererWorker.webContents.executeJavaScript(`getMisspelled(${JSON.stringify(words)})`);
8989

90-
const getUseNativeSpellChecker = () => {
91-
// eslint-disable-next-line no-warning-comments
92-
// TODO: always use native spellcheck until there's a fix for
93-
// https://github.com/electron/electron/issues/44336
94-
return true;
95-
// return loadSettings().useNativeSpellChecker;
96-
};
90+
const getUseNativeSpellChecker = () => loadSettings().useNativeSpellChecker;
9791

9892
const getEnabledDictionaries = () => loadSettings().enabledDictionaries;
9993

0 commit comments

Comments
 (0)