Modify methods to include logic for locality #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line 'joins(:zone_members).where(matching_city.or(matching_state.or(matching_country))).distinct' is the query that is used to decide if it is going to create a new ShippingRate that links the Shipment with the ShippingMethod
ccarruitero
suggested changes
Jun 7, 2021
There was a problem hiding this comment.
Thanks @kitpao , sorry for delay in review.
Could you add some specs for these methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line 'joins(:zone_members).where(matching_city.or(matching_state.or(matching_country))).distinct' is the query that is used to decide if it is going to create a new ShippingRate that links the Shipment with the ShippingMethod. So it is modified to include the matching_city
Also added the locality object whenever there was logic with the State or Country object