Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Magento\Sales\Api\Data\OrderInterface::getShippingAddress is gone in 2.0.0-RC2 #2382

Closed
mwr opened this issue Nov 16, 2015 · 5 comments
Closed

Comments

@mwr
Copy link
Contributor

mwr commented Nov 16, 2015

With the commit 6c1a87a the method getShippingAddress is removed from the \Magento\Sales\Api\Data\OrderInterface.

I don't get why this has been done.

I know that virtual orders don't need a ShippingAddress, but in this case it should just return null.

Can anybody clear things up a bit?

@antonkril
Copy link
Contributor

To support more complicated shipping scenarios, shipping address should be linked to order item shipping information. So to support this in future, shipping address was removed from order.

@cmuench
Copy link
Contributor

cmuench commented Nov 16, 2015

@antonkril I think such changes should not be done close before final release in a RC.

@mwr
Copy link
Contributor Author

mwr commented Nov 16, 2015

@antonkril thank you for the clarifcation. But that brings me to my next question, how can I retrieve the ShippingAddress when working against the OrderInterface / OrderItemInterface?

@fooman
Copy link
Contributor

fooman commented Nov 17, 2015

Changing something this late is bad enough, however I am even more concerned about the lack of adherence to semantic versioning. Removing anything from the API is backwards incompatible and should have triggered a major version update for the Magento_Sales module.

@antonkril
Copy link
Contributor

@cmuench @fooman agree with your comments. After we release stable version of product, versioning and code stability will be enforced by static tools to prevent such situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants