Wishlist: product with price 0 will break "My wishlist"

[jakwinkler]

Preconditions (*)

1. Magento 2.2.7

Steps to reproduce (*)

1. Create a simple product with price = 0
2. Create user account on frontend
3. Add created product to wishlist
4. Visit My Wishlist page

Expected result (*)

1. Wishlist page visible without any issues

Actual result (*)

1. Broken styling
2. Error in server files: "PHP Fatal error: Uncaught TypeError: Argument 1 passed to Magento\\Catalog\\Pricing\\Price\\ConfiguredOptions::getItemOptionsValue() must be of the type float, boolean given"

The problem is this file vendor/magento/module-catalog/Pricing/Price/RegularPrice.php in getValue method

It should return 0, not false, because this class vendor/magento/module-catalog/Pricing/Price/ConfiguredOptions.php

requires FLOAT parameter, not BOOLEAN
public function getItemOptionsValue(float $basePrice, ItemInterface $item): float

Simple and easy to fix :-)

[magento-engcom-team]

Hi @qsolutions-pl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@qsolutions-pl do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[shikhamis11]

@magento-engcom-team give me 2.2-develop instance

[magento-engcom-team]

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-21949-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[shikhamis11]

@qsolutions-pl this issue is not reproduceable at current 2.2-develop instance or 2.3-develop instance . It seems it is already fixed. Let me know here if you are still facing this issue in latest versions

[duckchip]

I was able to reproduce this issue on Magento 2.2.5

[duckchip]

@qsolutions-pl This is the fix.
#16537