Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve pedantic linting CI checks #109

Open
raehik opened this issue Dec 6, 2023 · 0 comments
Open

Resolve pedantic linting CI checks #109

raehik opened this issue Dec 6, 2023 · 0 comments
Labels
post-iccs-2023 Issues created during the ICCS 2023 project, but not completed.

Comments

@raehik
Copy link
Contributor

raehik commented Dec 6, 2023

We added GitHub CI earlier which checks some PyTests and runs some linting checks. Those linting checks complain a lot e.g. a line for every function missing a docstring, and are failing on main.

Should we enforce a particular style & keep these CI checks? Should we forget about them? Should we just have recommendations without linting CI, and retain instructions for running local checks? (I'm not very opinionated on Python style, so my first choice would be to not to enforce anything.)

Supplants #16 .

@raehik raehik added the post-iccs-2023 Issues created during the ICCS 2023 project, but not completed. label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-iccs-2023 Issues created during the ICCS 2023 project, but not completed.
Projects
None yet
Development

No branches or pull requests

1 participant