Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish neural net refactor at models/fully_conv_net.py #108

Open
raehik opened this issue Dec 6, 2023 · 1 comment
Open

Finish neural net refactor at models/fully_conv_net.py #108

raehik opened this issue Dec 6, 2023 · 1 comment
Labels
post-iccs-2023 Issues created during the ICCS 2023 project, but not completed.

Comments

@raehik
Copy link
Contributor

raehik commented Dec 6, 2023

#20 / #39 added a module models/fully_conv_net.py refactored from models/models1.py, which holds some basic PyTorch neural net architecture. We never started using it, though-- #43 tracked the work to swap from the old to refactored modules.

We should clean up related code if we're to use it. The "mixin" superclasses and final_transformation code are wonky, and should be simplified.

Supplants #40 , #43 .
This was referenced Dec 6, 2023
Closed
Closed
@raehik
Copy link
Contributor Author

raehik commented Dec 6, 2023

See #63 for another related issue.

@raehik raehik added the post-iccs-2023 Issues created during the ICCS 2023 project, but not completed. label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post-iccs-2023 Issues created during the ICCS 2023 project, but not completed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raehik