Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-#447: Add note about installation and setup in README #449

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

cgarciae
Copy link
Contributor

Overview

Its not a full solution for wrong installations but having a small note at the beginning of the Getting Started that guides users to correctly installing lux-api instead of lux and informing/reminding them they need to install the jupyter extension might help on this regard.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #449 (fe62e5d) into master (a7e2cf7) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head fe62e5d differs from pull request most recent head 27b76fc. Consider uploading reports for the commit 27b76fc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   65.65%   65.60%   -0.05%     
==========================================
  Files          55       55              
  Lines        4440     4440              
==========================================
- Hits         2915     2913       -2     
- Misses       1525     1527       +2     
Impacted Files Coverage Δ
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (-3.45%) ⬇️
lux/vislib/altair/ScatterChart.py 93.93% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e2cf7...27b76fc. Read the comment docs.

@dorisjlee dorisjlee changed the title Note about installation and setup in Getting Started DOCS-#447: Add note about installation and setup in README Jan 30, 2022
@dorisjlee dorisjlee merged commit ae2d55e into master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants