-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#419: Handle incompatibility issues between timedelta64 dtypes with Altair #444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 65.63% 65.60% -0.03%
==========================================
Files 55 55
Lines 4423 4440 +17
==========================================
+ Hits 2903 2913 +10
- Misses 1520 1527 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, can we indicate on the visualization labels that the attribute is now "attr [secs]"?
@dorisjlee what is the best way to do this? Is it just changing the column name or something more fancy? |
We can do this the same way we set an axis title like we do for the Histogram "axis_name (binned)" for Altair and Matplotlib (see example source). |
Overview
Fixes #419 by handling
timedelta64
columns insanitize_dataframe
.Changes
timedelta64
andinterval
dtypes.timedelta64
columns todt.seconds
inside thesanitize_dataframe
function.