Merge Master Branch Changes Updated test_vis.py #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-org#304) * Merge upstream * Sync with master * Fix bin size variance from lux-org#217 * Format and test * Change labelOverlap to True Co-authored-by: Dominik Moritz <domoritz@gmail.com> * Modify markbar; currently questioning whether or not it's needed * Remove markbar enitrely, rely on Altair automatic bin detection https://altair-viz.github.io/user_guide/generated/core/altair.BinParams.html * Modify code snippet * Revert "Remove markbar enitrely, rely on Altair automatic bin detection https://altair-viz.github.io/user_guide/generated/core/altair.BinParams.html" This reverts commit 9cb9418. * Implement bin size estimation via Freedman Diaconis's Rule * Use numpy to compute IQR for better performance (pandas too slow) * Add tests * Add test cases for histogram binning * Address changes from @domoritz review (small optimizations) * Black and format * Move histogram bin width computation to pandas executor (execute_binning) * Center bars between ticks in distribution setting * Renaming in execute_binning * Bin width computed accurately in execute_binning; no need for get_bin_size() * Revert to Freedman rule; maintain correct ticks * Sync exported code with new histogram bin determination rules * Sync exported code with new histogram bin determination rules * Modify histogram code test case Co-authored-by: Micah Yong <micahyong@Micahs-MacBook-Pro.local> Co-authored-by: Dominik Moritz <domoritz@gmail.com>
Added disclaimer for the data preview
* add series equality and value counts test * black formatting * fix old value counts test instead * add pandas tests * remove str from column group * save work on groupby bugs so far * fix merge conflict again * add new tests and add groupby bug fixes * remove tests for staging * update series tests * add back getitem * fix merge conflicts for staging * remove print statements * revert Makefile * add test for name column case * add test to ensure column is not all None * re-add tests and commit new groupby implementation * make parent LuxGroupby * reformat LuxGroupBy and fix SeriesGroupby issue * remove pandas tests * run black * finish seriesgroupby metadata propagation and add test * run black
* rec series * rec * add changes back * fix tests * rm * change * set plotting_style * nice * black * rm * change rec * reuse export * change size of plot * rm * ref * fixed * reform * enlarge font * enlarge font Co-authored-by: Caitlyn Chen <caitlynachen@berkeley.edu>
Removed unnecessary print statement and redundant initialization of test dataframe
Removed unnecessary parameter initialization in the LuxSQLTable init function as they are being set in the super constructor.
Issue when running test_vis in Github Actions. Adjusted test_scatter_chart and test_colored_scatter_chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Merged changes from master branch PR #309 and PR #286. Updated
test_vis.pysince there was an issue within Github Actions' test environment.Changes
Seems like Github Actions was not properly decoding a string within
test_vis.py, updated the test criteria fortest_scatter_chart()andtest_colored_scatter_chart()to work within the test environment.